after_the_tremor_combat no longer works as expected

[wjt]

In this scene there are two player-characters and the enemy flings projectiles at each at random. You are supposed to hit the correct key (left or right) to repel the projectile back to the enemy, damaging it (via a hidden filling barrel at its feet).

But it no longer works. The projectiles fly off at different angles and don't hit the enemy.

XP Summary (total 575)

Subdomain	Skill	XP
Game Design: Core Gameplay & Mechanics	Problem Solving	150
Game Design: Core Gameplay & Mechanics	Creativity & Design Thinking	50
Game Design: Core Gameplay & Mechanics	Technical Literacy	75
Engineering: Gameplay & Systems Programming	Problem Solving	75
Engineering: Gameplay & Systems Programming	Creativity & Design Thinking	75
Engineering: Gameplay & Systems Programming	Technical Literacy	150

[wjt]

I bisected the "can't damage the enemy" problem: it was introduced in commit c7729e3 (#2088).

Gameplay-wise, before that commit the projectiles were repelled directly back along the path they were fired on. Now, they ricochet off at different angles.

But the filling barrel is only placed directly at the base of the enemy.

[wjt]

I have to say I don't understand why that commit changed the repel behaviour: it did move the "direction between player and projectile" calculation from the projectile to the player_repel component, but the calculation looks the same to me...

[manuq]

@wjt thanks for bisecting. I will try to fix it.

[wjt]

@felixwalberg I think you may have fixed this in #2464?