-
Notifications
You must be signed in to change notification settings - Fork 0
Explainer #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Explainer #1
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # template-for-proposals | ||
|
|
||
| A repository template for ECMAScript proposals. | ||
|
|
||
| ## Before creating a proposal | ||
|
|
||
| Please ensure the following: | ||
| 1. You have read the [process document](https://tc39.github.io/process-document/) | ||
| 1. You have reviewed the [existing proposals](https://github.com/tc39/proposals/) | ||
| 1. You are aware that your proposal requires being a member of TC39, or locating a TC39 delegate to “champion” your proposal | ||
|
|
||
| ## Create your proposal repo | ||
|
|
||
| Follow these steps: | ||
| 1. Click the green [“use this template”](https://github.com/tc39/template-for-proposals/generate) button in the repo header. (Note: Do not fork this repo in GitHub's web interface, as that will later prevent transfer into the TC39 organization) | ||
| 1. Update ecmarkup and the biblio to the latest version: `npm install --save-dev ecmarkup@latest && npm install --save-dev --save-exact @tc39/ecma262-biblio@latest`. | ||
| 1. Go to your repo settings page: | ||
| 1. Under “General”, under “Features”, ensure “Issues” is checked, and disable “Wiki”, and “Projects” (unless you intend to use Projects) | ||
| 1. Under “Pull Requests”, check “Always suggest updating pull request branches” and “automatically delete head branches” | ||
| 1. Under the “Pages” section on the left sidebar, and set the source to “deploy from a branch”, select “gh-pages” in the branch dropdown, and then ensure that “Enforce HTTPS” is checked. | ||
| 1. Under the “Actions” section on the left sidebar, under “General”, select “Read and write permissions” under “Workflow permissions” and click “Save” | ||
| 1. [“How to write a good explainer”][explainer] explains how to make a good first impression. | ||
|
|
||
| > Each TC39 proposal should have a `README.md` file which explains the purpose | ||
| > of the proposal and its shape at a high level. | ||
| > | ||
| > ... | ||
| > | ||
| > The rest of this page can be used as a template ... | ||
|
|
||
| Your explainer can point readers to the `index.html` generated from `spec.emu` | ||
| via markdown like | ||
|
|
||
| ```markdown | ||
| You can browse the [ecmarkup output](https://ACCOUNT.github.io/PROJECT/) | ||
| or browse the [source](https://github.com/ACCOUNT/PROJECT/blob/HEAD/spec.emu). | ||
| ``` | ||
|
|
||
| where *ACCOUNT* and *PROJECT* are the first two path elements in your project's Github URL. | ||
| For example, for github.com/**tc39**/**template-for-proposals**, *ACCOUNT* is “tc39” | ||
| and *PROJECT* is “template-for-proposals”. | ||
|
|
||
|
|
||
| ## Maintain your proposal repo | ||
|
|
||
| 1. Make your changes to `spec.emu` (ecmarkup uses HTML syntax, but is not HTML, so I strongly suggest not naming it “.html”) | ||
| 1. Any commit that makes meaningful changes to the spec, should run `npm run build` to verify that the build will succeed and the output looks as expected. | ||
| 1. Whenever you update `ecmarkup`, run `npm run build` to verify that the build will succeed and the output looks as expected. | ||
|
|
||
| [explainer]: https://github.com/tc39/how-we-work/blob/HEAD/explainer.md | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this guide to contributing a proposal mistakenly copied from the template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than delete it, I moved it out of the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you? forgot to push?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally fine to delete it too, the content's visible on the template and in the history :-p