Details fleshed out#2
Merged
Merged
Conversation
|
The rendered spec for this PR is available at https://endojs.github.io/proposal-new-global/pr/2. |
kriskowal
force-pushed
the
kriskowal-flesh-out
branch
from
91d4135 to
c519459
Compare
Member
Author
|
Please leave your reviews. We will adapt in follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably, I realized that the new
ModuleSourcedoes not require every global to have its own, and also thatglobalThisdoesn’t have animportmethod, which obligates the user to callglobalThat.eval('(...args) => import(...args))to bind their own.Adapted motivations from Evaluators.
I narrowed down the design to
keysbeing copied by property descriptor, but forced configurable.