fix type hints for recording the results to a list of dictionaries.

Author: enetheru

.github/workflows/ci-cmake.yml

@@ -161,7 +161,7 @@ jobs:
         run: cmake --build cmake-build --verbose  --target godot-cpp-test ${{ matrix.build-flags }}
 
       - name: Run sccache stat for check
-        run: ${{ env.SCCACHE_PATH }} --show-stats >> ${{ env.GITHUB_STEP_SUMMARY }}
+        run: ${{ env.SCCACHE_PATH }} --show-stats >> $GITHUB_STEP_SUMMARY
         env:
           GITHUB_STEP_SUMMARY: ${{ env.GITHUB_STEP_SUMMARY }}
 

test/run-tests.py

@@ -16,7 +16,7 @@
 import urllib.request
 import zipfile
 from pathlib import Path
-from typing import List, Tuple
+from typing import Any, Dict, List, Tuple
 
 # ----------------------------------------------
 # Configuration
@@ -184,13 +184,10 @@ def find_binary(pattern_part):
 # ----------------------------------------------
 # Helpers
 # ----------------------------------------------
-def record_test_result(results: list, version: str, success: bool, duration: int):
+def record_test_result(results: List[Dict[str, Any]], version: str, success: bool, duration: int) -> None:
     status = "✅ PASSED" if success else "❌ FAILED"
-    results.append({
-        "godot_version": version or "master",
-        "status": status,
-        "duration_seconds": duration
-    })
+    results.append({"godot_version": version or "master", "status": status, "duration_seconds": duration})
+
 
 def vprint(*args, **kwargs):
     if verbose:
@@ -574,7 +571,6 @@ def silent(*_args, **_kwargs):
 
     overall_success = True
 
-
     results = []  # list of dicts for table + JSON
 
     for version in versions:
@@ -643,9 +639,9 @@ def silent(*_args, **_kwargs):
                 # Simple ASCII bar chart of current run durations (max bar = 60 chars)
                 if results:
                     f.write("\n### Duration (seconds)\n")
-                    max_dur = max(r['duration_seconds'] for r in results)
+                    max_dur = max(r["duration_seconds"] for r in results)
                     for r in results:
-                        bar_len = int(60 * r['duration_seconds'] / max_dur) if max_dur > 0 else 0
+                        bar_len = int(60 * r["duration_seconds"] / max_dur) if max_dur > 0 else 0
                         bar = "█" * bar_len
                         f.write(f"{r['godot_version']:13} |{bar} {r['duration_seconds']}s\n")
         except Exception:
@@ -655,13 +651,18 @@ def silent(*_args, **_kwargs):
     metrics_path = SCRIPT_DIR / "test-metrics.json"
     try:
         import json
+
         with open(metrics_path, "w", encoding="utf-8") as f:
-            json.dump({
-                "timestamp": time.strftime("%Y-%m-%d %H:%M:%S UTC", time.gmtime()),
-                "platform": os.environ.get("RUNNER_OS", "unknown"),
-                "runner": os.environ.get("RUNNER_NAME", "unknown"),
-                "results": results
-            }, f, indent=2)
+            json.dump(
+                {
+                    "timestamp": time.strftime("%Y-%m-%d %H:%M:%S UTC", time.gmtime()),
+                    "platform": os.environ.get("RUNNER_OS", "unknown"),
+                    "runner": os.environ.get("RUNNER_NAME", "unknown"),
+                    "results": results,
+                },
+                f,
+                indent=2,
+            )
     except Exception:
         pass