Skip to content

Commit a9211f3

Browse files
engalarclaude
andcommitted
fix: address PR mendixlabs#68 review + migrate filter widgets to engine
Review fixes: - Remove 7 debug log.Printf calls + timelineCustom debug block - deepCloneMap returns error instead of silent nil - Mode fallback returns error for ambiguous multiple defaults - createAttributeObject validates path format upfront - Association mapping validates EntityName is set Engine migration: - Add attributeObjects operation for Attributes: [...] → BSON Objects - Create .def.json for TEXTFILTER/NUMBERFILTER/DROPDOWNFILTER/DATEFILTER - Delete ~200 lines of hardcoded filter builders - Add DROPDOWNSORT full-stack (lexer/parser/describe/def.json) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 61066c0 commit a9211f3

19 files changed

Lines changed: 4435 additions & 4699 deletions

mdl/executor/cmd_pages_builder_v3.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -311,14 +311,6 @@ func (pb *pageBuilder) buildWidgetV3(w *ast.WidgetV3) (pages.Widget, error) {
311311
widget, err = pb.buildTemplateV3(w)
312312
case "FILTER":
313313
widget, err = pb.buildFilterV3(w)
314-
case "TEXTFILTER":
315-
widget, err = pb.buildTextFilterV3(w)
316-
case "NUMBERFILTER":
317-
widget, err = pb.buildNumberFilterV3(w)
318-
case "DROPDOWNFILTER":
319-
widget, err = pb.buildDropdownFilterV3(w)
320-
case "DATEFILTER":
321-
widget, err = pb.buildDateFilterV3(w)
322314
case "STATICIMAGE":
323315
widget, err = pb.buildStaticImageV3(w)
324316
case "DYNAMICIMAGE":

0 commit comments

Comments
 (0)