Commit d75596d
committed
refactor(tui): address PR #23 review, move bson/ tui/ to cmd/mxcli/
Fix all critical and moderate issues from code review:
- Fix itoa() for tab numbers >= 10 (#1)
- Add TabID to LoadTreeMsg to prevent race condition (#2)
- Fix UTF-8 truncation with runewidth (#3)
- Change View()/viewZen() to pointer receivers (#4)
- Cancel PreviewEngine on tab close and app quit (#5)
- Remove ~315 lines dead code in keys.go (#6)
- Remove unused NavState, MillerFocusPreview, GoBack, ToggleZen (#7)
- Reset traceActive in CloseTrace() (#8)
- Remove nolint:govet suppression (#9)
- Extract magic numbers as named constants (#10)
- Handle openDiagram temp file cleanup and WriteString error (#11)
- Remove redundant rebuildZones() call (#12)
- Fallback NDSL preview to MDL DESCRIBE for unsupported types
- Move bson/ and tui/ packages into cmd/mxcli/ per reviewer suggestion1 parent 8f75145 commit d75596d
37 files changed
Lines changed: 96 additions & 409 deletions
File tree
- cmd/mxcli
- bson
- tui
- tui
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments