Skip to content

Commit d75596d

Browse files
committed
refactor(tui): address PR #23 review, move bson/ tui/ to cmd/mxcli/
Fix all critical and moderate issues from code review: - Fix itoa() for tab numbers >= 10 (#1) - Add TabID to LoadTreeMsg to prevent race condition (#2) - Fix UTF-8 truncation with runewidth (#3) - Change View()/viewZen() to pointer receivers (#4) - Cancel PreviewEngine on tab close and app quit (#5) - Remove ~315 lines dead code in keys.go (#6) - Remove unused NavState, MillerFocusPreview, GoBack, ToggleZen (#7) - Reset traceActive in CloseTrace() (#8) - Remove nolint:govet suppression (#9) - Extract magic numbers as named constants (#10) - Handle openDiagram temp file cleanup and WriteString error (#11) - Remove redundant rebuildZones() call (#12) - Fallback NDSL preview to MDL DESCRIBE for unsupported types - Move bson/ and tui/ packages into cmd/mxcli/ per reviewer suggestion
1 parent 8f75145 commit d75596d

37 files changed

Lines changed: 96 additions & 409 deletions
File renamed without changes.

cmd/mxcli/cmd_bson_compare.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"fmt"
55
"os"
66

7-
bsondebug "github.com/mendixlabs/mxcli/bson"
7+
bsondebug "github.com/mendixlabs/mxcli/cmd/mxcli/bson"
88
"github.com/mendixlabs/mxcli/sdk/mpr"
99
"github.com/spf13/cobra"
1010
"go.mongodb.org/mongo-driver/bson"

0 commit comments

Comments
 (0)