Merge pull request #7 from engali94/bug/std

#2 Use std feature instead no_std

Author: engali94

.github/workflows/ci.yml

@@ -40,14 +40,21 @@ jobs:
       if: matrix.rust == 'stable'
       run: cargo clippy --all-targets -- -D warnings
 
+    - name: Run clippy (no_std)
+      if: matrix.rust == 'stable'
+      run: cargo clippy --all-targets --no-default-features -- -D warnings
+    
     - name: Build
       run: cargo build --verbose
 
     - name: Run tests
       run: cargo test --verbose
 
     - name: Run tests (no_std)
-      run: cargo test --no-default-features --features no_std --verbose
+      run: cargo test --no-default-features --verbose
+    
+    - name: Check no_std compilation
+      run: cargo check --no-default-features --verbose
 
     - name: Run tests (nightly features)
       if: matrix.rust == 'nightly'

Cargo.toml

@@ -11,8 +11,8 @@ readme = "README.md"
 edition = "2021"
 
 [features]
-default = []
-no_std = []
+default = ["std"]
+std = []
 nightly = []
 
 [dev-dependencies]

README.md

@@ -104,12 +104,12 @@ let reference: &str = unsafe { data.ptr.as_ref_unchecked() };
 
 ## Features
 
-- **`no_std`**: Works in embedded environments
+- **`no_std`**: Works in embedded environments (disable default `std` feature)
 - **`nightly`**: Trait object support with nightly Rust
 
 ```toml
 [dependencies]
-movable-ref = { version = "0.1.0", features = ["no_std"] }
+movable-ref = { version = "0.1.0", default-features = false }
 ```
 ## Performance Benchmarks
 

src/error.rs

@@ -14,7 +14,7 @@ pub(crate) enum IntegerOffsetErrorImpl {
     Sub(usize, usize),
 }
 
-#[cfg(not(feature = "no_std"))]
+#[cfg(feature = "std")]
 impl std::error::Error for IntegerOffsetError {}
 
 mod fmt {

src/lib.rs

@@ -1,4 +1,4 @@
-#![cfg_attr(feature = "no_std", no_std)]
+#![cfg_attr(not(feature = "std"), no_std)]
 #![cfg_attr(feature = "nightly", feature(ptr_metadata))]
 #![allow(clippy::needless_doctest_main)]
 #![forbid(missing_docs)]
@@ -19,7 +19,17 @@ See the `SelfRef` type documentation for safety information.
 
 ### `no_std`
 
-This crate is `no_std` compatible. Enable the `no_std` feature to use without the standard library.
+This crate is `no_std` compatible. Disable the `std` feature to use without the standard library.
+
+```toml
+# For no_std environments (embedded systems, etc.)
+[dependencies]
+movable-ref = { version = "0.1.0", default-features = false }
+
+# For std environments (default)
+[dependencies]
+movable-ref = "0.1.0"
+```
 
 ## Example
 
@@ -116,7 +126,7 @@ be invalidated - which occurs when direct pointer modification is impossible
 and field offsets remain constant after initialization.
 */
 
-#[cfg(feature = "no_std")]
+#[cfg(not(feature = "std"))]
 extern crate core as std;
 
 #[cfg(test)]

src/metadata/impls.rs

@@ -2,9 +2,9 @@ use super::traits::PointerRecomposition;
 use crate::offset::Ptr;
 use std::ptr::NonNull;
 
-#[cfg(feature = "no_std")]
+#[cfg(not(feature = "std"))]
 extern crate alloc;
-#[cfg(feature = "no_std")]
+#[cfg(not(feature = "std"))]
 use alloc::{string::String, vec::Vec};
 
 unsafe impl<T: ?Sized> PointerRecomposition for &T {

src/tests.rs

@@ -168,7 +168,7 @@ mod nightly {
 
         assert_eq!(s.t().value, 42);
 
-        #[cfg(not(feature = "no_std"))]
+        #[cfg(feature = "std")]
         {
             let debug_str = format!("{:?}", s.t_ref().as_ref());
             assert!(debug_str.contains("42"));
@@ -183,7 +183,7 @@ mod nightly {
 
         assert_eq!(s.t().value, 42);
 
-        #[cfg(not(feature = "no_std"))]
+        #[cfg(feature = "std")]
         {
             let debug_str = format!("{:?}", s.t_ref().as_ref());
             assert!(debug_str.contains("42"));
@@ -198,23 +198,23 @@ mod nightly {
 
         assert_eq!(s.t().value, 42);
 
-        #[cfg(not(feature = "no_std"))]
+        #[cfg(feature = "std")]
         {
             let debug_str = format!("{:?}", s.t_ref().as_ref());
             assert!(debug_str.contains("42"));
         }
     }
 
     #[test]
-    #[cfg(not(feature = "no_std"))]
+    #[cfg(feature = "std")]
     fn check_trait_object_after_move_heap() {
         let s = SelfRefTest::new(TestStruct { value: 42 }, |x| unsafe {
             TraitObject::from_mut(x as &mut dyn std::fmt::Debug)
         });
 
         assert_eq!(s.t().value, 42);
 
-        #[cfg(not(feature = "no_std"))]
+        #[cfg(feature = "std")]
         {
             let debug_str = format!("{:?}", s.t_ref().as_ref());
             assert!(debug_str.contains("42"));
@@ -224,7 +224,7 @@ mod nightly {
 
         assert_eq!(s.t().value, 42);
 
-        #[cfg(not(feature = "no_std"))]
+        #[cfg(feature = "std")]
         {
             let debug_str = format!("{:?}", s.t_ref().as_ref());
             assert!(debug_str.contains("42"));