Skip to content

TERNA PR4 & PR5 (Update machinev1) #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smazzucco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

TERNA PR4 & PR5 (Update machinev1) #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions working_copy/machinev1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,6 @@
"expanded": "Distributed Denial of Service",
"value": "ddos"
},
{
"description": "Software misconfiguration resulting in service availability issues, e.g., DNS server with outdated DNSSEC Root Zone KSK.",
"expanded": "Misconfiguration",
"value": "misconfiguration"
},
{
"description": "Physical sabotage, e.g., cutting wires or malicious arson.",
"expanded": "Sabotage",
Expand Down Expand Up @@ -225,6 +220,16 @@
],
"predicate": "vulnerable"
},
{
"entry": [
{
"description": "Software misconfiguration resulting in service availability issues, e.g., DNS server with outdated DNSSEC Root Zone KSK.",
"expanded": "Misconfiguration",
"value": "misconfiguration"
}
],
"predicate": "accidental event"
},
{
"entry": [
{
Expand All @@ -238,7 +243,7 @@
"value": "undetermined"
}
],
"predicate": "other"
"predicate": "accidental event"

@sebix sebix May 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the "other" taxonomy renamed? that's a major change with big impact

@smazzucco smazzucco May 26, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not renamed. I copied the part to introduce "Accidental Event" Category including "Misconfiguration" example (takem from "Availability")

@sebix sebix May 29, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You created accidental event by copying it, yes. But you also modified the other-taxonomy as these two lines clearly show.

},
{
"entry": [
Expand Down Expand Up @@ -297,6 +302,11 @@
"expanded": "Vulnerable",
"value": "vulnerable"
},
{
"description": "Accidental events not linked to a willful will, such as misconfigurations.",
"expanded": "Accidental Event (No Malice)",
"value": "accidental event"
},
{
"description": "All incidents which don't fit in one of the given categories should be put into this class. If the number of incidents in this category increases, it is an indicator that the classification scheme must be revised.",
"expanded": "Other",
Expand Down