Skip to content

Commit c9da7db

Browse files
authored
Run H5 tests on Apple Silicon, for Python >= 3.10
Closes #344 This PR weakens an earlier restriction that meant that we didn't run the HDF5-related tests on Apple Silicon. That restriction now only applies for the _combination_ of macOS and Python < 3.10.
1 parent 09bd198 commit c9da7db

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/test-with-pip.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ jobs:
2020
uses: actions/setup-python@v5
2121
with:
2222
python-version: ${{ matrix.python-version }}
23-
- name: Install dependencies and local packages (not macOS)
23+
- name: Install dependencies and local packages
2424
run: python -m pip install .[gui,h5,preferences]
25-
if: matrix.os != 'macos-latest'
26-
- name: Install dependencies and local packages (macOS)
25+
if: (matrix.os != 'macos-latest') || ((matrix.python-version != '3.8') && (matrix.python-version != '3.9'))
26+
- name: Install dependencies and local packages (exclude h5)
2727
run: python -m pip install .[gui,preferences]
28-
# PyTables currently won't build on Apple Silicon, so exclude the h5 deps
28+
# PyTables won't build on Apple Silicon for Python < 3.10, so exclude
29+
# the h5 dependency.
2930
# xref: enthought/apptools/issues/344
30-
if: matrix.os == 'macos-latest'
31+
if: (matrix.os == 'macos-latest') && ((matrix.python-version == '3.8') || (matrix.python-version == '3.9'))
3132
- name: Run tests
3233
run: |
3334
mkdir testdir

0 commit comments

Comments
 (0)