test(e2e): cover git-refs backend on push + assert no v1 branch#1820
Open
gtrrz-victor wants to merge 1 commit into
Open
test(e2e): cover git-refs backend on push + assert no v1 branch#1820gtrrz-victor wants to merge 1 commit into
gtrrz-victor wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the E2E harness/CI workflows to cover the git-refs checkpoint backend (the default for fresh entire enable setups) and adds a regression guard to ensure the legacy entire/checkpoints/v1 branch is not accidentally created under git-refs.
Changes:
- Add a
SetupRepocleanup guard (git-refs only) that fails the test if a localentire/checkpoints/v1branch exists. - Make
e2e-checkpoint-store.ymlreusable viaworkflow_calland unify input access throughinputs.*. - Add an
e2e-git-refsjob to the on-push E2E workflow and include it in Slack failure detection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
e2e/testutil/repo.go |
Adds a git-refs-only cleanup assertion preventing accidental v1 branch creation. |
.github/workflows/e2e.yml |
Adds a dedicated git-refs E2E job and includes it in Slack failure gating. |
.github/workflows/e2e-checkpoint-store.yml |
Adds workflow_call support and standardizes on inputs.* for dispatch/call. |
gtrrz-victor
marked this pull request as draft
July 21, 2026 11:41
Two changes to lock in the git-refs checkpoint backend (the default for fresh `entire enable` setups) as an exercised, guarded path: 1. Per-test guard: SetupRepo now registers a cleanup (only under the git-refs backend) that fails the test if a local entire/checkpoints/v1 branch exists. Under git-refs, checkpoints live in per-checkpoint refs and nothing should ever seed v1; a v1 branch means a flow regressed. 2. CI coverage: the on-push e2e.yml matrix pins git-branch, so git-refs had no automatic coverage. Make e2e-checkpoint-store.yml callable (workflow_call) and add an e2e-git-refs job to e2e.yml that runs on every push to main, wired into the Slack failure notification. The agent (claude-code) and backend (git-refs) are fixed by the reusable workflow's input defaults, so the caller parameterizes neither and the leg always covers exactly one agent on one backend. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 01KY4RVXK1PCVYV31TMC73VS6P
gtrrz-victor
force-pushed
the
e2e-git-refs-no-v1-branch
branch
from
July 22, 2026 11:20
6cbf6ce to
cd9d8cd
Compare
gtrrz-victor
marked this pull request as ready for review
July 22, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/911
Why this matters
Fresh
entire enablenow defaults to the git-refs backend — but every automatic E2E run pins git-branch. The backend real users get on day one had zero E2E coverage, and that gap is exactly how the v1-orphan bug (#1819) shipped unnoticed.What this does
repo.go): every git-refs E2E test now fails if anentire/checkpoints/v1branch appears. Under git-refs, nothing should ever create v1 — so this catches any future flow that regresses like fix: skip empty v1 orphan seed under git-refs backend #1819 did.e2e.yml+e2e-checkpoint-store.yml): aclaude-code×git-refsleg on every push tomain, in Slack notify. Agent and backend are fixed by the reusable workflow's defaults (caller passes nothing) — one agent, to bound cost.Verified
go vet -tags e2e(testutil + tests),gofmt, YAML parse,actionlint(only pre-existing findings). Real E2E not run locally (API cost); it runs in the new CI leg.