Skip to content

test(import): fully isolate git config in author fallback test #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtrrz-victor merged 1 commit into from
Jul 24, 2026
+13 −2
Merged

test(import): fully isolate git config in author fallback test #1849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions cmd/entire/cli/agentimport/agentimport_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,11 +438,22 @@ func TestRun_StampsImporterGitAuthorOnCheckpointCommit(t *testing.T) {
// same "Unknown"/"unknown@local" default checkpoint.GetGitAuthorFromRepo
// already applies elsewhere, rather than an empty one.
func TestRun_UnconfiguredGitIdentityFallsBackToDefaults(t *testing.T) {
// Cannot use t.Parallel(): isolates HOME via t.Setenv so this repo's
// global git config resolution can't see the developer's real ~/.gitconfig.
// Cannot use t.Parallel(): isolates git config resolution via t.Setenv so
// this repo can't see any real identity. GetGitAuthorFromRepo resolves
// GlobalScope through go-git's Auto loader, which reads all of git's global
// sources; neutralize every one or the fallback assertion is flaky wherever
// an identity is configured (~/.gitconfig, XDG, GIT_CONFIG_GLOBAL, or system
// /etc/gitconfig). Mirrors the checkpoint package's pointHomeAt helper.
home := t.TempDir()
t.Setenv("HOME", home)
t.Setenv("XDG_CONFIG_HOME", "")
t.Setenv("GIT_CONFIG_NOSYSTEM", "1")
// t.Setenv registers restoration of the original value; unset it for the
// test since an empty GIT_CONFIG_GLOBAL disables global config entirely.
t.Setenv("GIT_CONFIG_GLOBAL", "")
if err := os.Unsetenv("GIT_CONFIG_GLOBAL"); err != nil {
t.Fatal(err)
}

repoDir := t.TempDir()
repo, err := git.PlainInit(repoDir, false)
Expand Down
Loading