Demonstrate using metrics#45
Merged
Merged
Conversation
Member
|
can you do the update to the latest commit hash in a separate PR and adding the new metrics API in a separate PR? |
Member
|
The main branch here can be pinned to any latest hash in other words |
wtzhang23
force-pushed
the
metrics-example
branch
from
53efd3f to
0500cfb
Compare
Contributor
Author
|
Will rebase to main once ready. |
wtzhang23
force-pushed
the
metrics-example
branch
3 times, most recently
from
fe1674b to
b593bd6
Compare
Signed-off-by: William Zhang <wtzhang23@gmail.com>
wtzhang23
force-pushed
the
metrics-example
branch
from
b593bd6 to
55a4012
Compare
Signed-off-by: William Zhang <wtzhang23@gmail.com>
mathetake
reviewed
Sep 26, 2025
mathetake
left a comment
mathetake
left a comment
Member
There was a problem hiding this comment.
do you want to add integration test case?
| /// | ||
| /// The trait corresponds to a Envoy filter chain configuration. | ||
| pub struct FilterConfig { | ||
| _filter_config: String, |
Signed-off-by: William Zhang <williamzhang@roblox.com>
Contributor
Author
|
Added integration test by parsing the prometheus output. Might be a little overkill. Let me know if you prefer just searching for |
Member
|
it's alright |
Member
|
looks good |
…eterministic Signed-off-by: William Zhang <williamzhang@roblox.com>
Contributor
Author
|
Oh oops I didn't like it so went ahead and made it simple lol |
Contributor
Author
|
Undid new change |
…uld be deterministic" This reverts commit 354ea16. Signed-off-by: William Zhang <williamzhang@roblox.com>
wtzhang23
force-pushed
the
metrics-example
branch
from
e3bf90c to
c2bc007
Compare
Member
|
marking ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example records the e2e latency of a route from when a request enters the filter to when it exits.
Depends on #46