Skip to content

add http server test#134

Open
helight wants to merge 2 commits into
envoyproxy:mainfrom
helight:add_test_config
Open

add http server test#134
helight wants to merge 2 commits into
envoyproxy:mainfrom
helight:add_test_config

Conversation

@helight

@helight helight commented Sep 29, 2020

Copy link
Copy Markdown
  1. Add an http server for testing http filter.
  2. Add config.yaml for testing http filter.
  3. Add readme for testing http filter instruction.

Signed-off-by: helight <helightxu@tencent.com>
@helight

helight commented Sep 29, 2020

Copy link
Copy Markdown
Author

@lizan please help to review this pr

@lizan lizan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some sort of test for this config? Like verify examples in envoy repo.

typed_config:
"@type": type.googleapis.com/sample.Decoder
key: via
key: Via

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: keep this lowercase

@helight helight Sep 30, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing this function
http_filter.cc

const LowerCaseString HttpSampleDecoderFilter::headerKey() const {
  return LowerCaseString(config_->key());
}

@helight

helight commented Sep 30, 2020

Copy link
Copy Markdown
Author

Can we have some sort of test for this config? Like verify examples in envoy repo.

Ok

Signed-off-by: helight <helightxu@tencent.com>
@helight

helight commented Oct 6, 2020

Copy link
Copy Markdown
Author

Can we have some sort of test for this config? Like verify examples in envoy repo.

@lizan I add a startup.sh and verify.sh, please help to check

Base automatically changed from master to main January 15, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants