Skip to content

Commit 88aa8e3

Browse files
committed
Trying to fix coverage.
Signed-off-by: Biren Roy <birenroy@google.com>
1 parent 677b32f commit 88aa8e3

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

test/common/http/http2/codec_impl_test.cc

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4592,9 +4592,7 @@ TEST_P(Http2CodecImplTest, ChunkProcessingShouldNotScheduleIfReadDisabled) {
45924592
}
45934593

45944594
TEST_P(Http2CodecImplTest, ServerDispatchLoadShedPointCanCauseServerToSendGoAway) {
4595-
if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.http2_fix_goaway_loadshed_point")) {
4596-
GTEST_SKIP();
4597-
}
4595+
Runtime::maybeSetRuntimeGuard("envoy.reloadable_features.http2_fix_goaway_loadshed_point", false);
45984596
initialize();
45994597
ASSERT_EQ(0, server_stats_store_.counter("http2.goaway_sent").value());
46004598

@@ -4616,9 +4614,7 @@ TEST_P(Http2CodecImplTest, ServerDispatchLoadShedPointCanCauseServerToSendGoAway
46164614
}
46174615

46184616
TEST_P(Http2CodecImplTest, ServerDispatchLoadShedPointSendGoAwayAndClose) {
4619-
if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.http2_fix_goaway_loadshed_point")) {
4620-
GTEST_SKIP();
4621-
}
4617+
Runtime::maybeSetRuntimeGuard("envoy.reloadable_features.http2_fix_goaway_loadshed_point", false);
46224618
expect_buffered_data_on_teardown_ = true;
46234619

46244620
initialize();
@@ -4639,9 +4635,7 @@ TEST_P(Http2CodecImplTest, ServerDispatchLoadShedPointSendGoAwayAndClose) {
46394635
}
46404636

46414637
TEST_P(Http2CodecImplTest, ServerDispatchLoadShedPointsAreOnlyConsultedOncePerDispatch) {
4642-
if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.http2_fix_goaway_loadshed_point")) {
4643-
GTEST_SKIP();
4644-
}
4638+
Runtime::maybeSetRuntimeGuard("envoy.reloadable_features.http2_fix_goaway_loadshed_point", false);
46454639

46464640
initialize();
46474641

0 commit comments

Comments
 (0)