Skip to content

dynamic_modules: allow user to set the stat prefix for dynamic module stats#41215

Closed
wtzhang23 wants to merge 1 commit into
envoyproxy:mainfrom
wtzhang23:dynamic-modules-stat-prefix
Closed

dynamic_modules: allow user to set the stat prefix for dynamic module stats#41215
wtzhang23 wants to merge 1 commit into
envoyproxy:mainfrom
wtzhang23:dynamic-modules-stat-prefix

Conversation

@wtzhang23

Copy link
Copy Markdown
Contributor

Commit Message: allow user to set the stat prefix for dynamic module stats
Additional Description: Provides the ability for the user to specify the string prefix prepended before all metrics created by their module
Risk Level: Low
Testing: Unit + Integration
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: William Zhang <wtzhang23@gmail.com>
@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41215 was opened by wtzhang23.

see: more, trace.

@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #41215 was opened by wtzhang23.

see: more, trace.

@wtzhang23

Copy link
Copy Markdown
Contributor Author

Not needed. See envoyproxy/dynamic-modules-examples#45 to see how the namespace prefix is stripped. Users can just specify the full metric name.

@wtzhang23 wtzhang23 closed this Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants