RLQS: Improve TlsStore persistence after filter factory deletion#44690
Draft
bsurber wants to merge 5 commits intoenvoyproxy:mainfrom
Draft
RLQS: Improve TlsStore persistence after filter factory deletion#44690bsurber wants to merge 5 commits intoenvoyproxy:mainfrom
bsurber wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
…inish-rlqs-fix
…TlsStore deletion outside of the main thread Signed-off-by: Brian Surber <bsurber@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Branch off of #44236 with some cleanup and improved coverage in filter_persistence_test.cc
Overall, this lets filter instances in worker threads hold shared_ptr ownership of TlsStores and the Global RLQS client (GlobalRateLimitClientImpl), guaranteeing their existence even if the filter factory (previous unique owner of both) gets deleted via an xDS push.
Operations posted to the main thread by the GlobalRateLimitClientImpl also now check to make sure they haven't outlived the original global client.
Additional Description:
Risk Level: minor (haven't been reproducible outside of direct coverage testing)
Testing: unit testing
Docs Changes:
Release Notes:
Platform Specific Features: