http2: Moves HTTP/2 GOAWAY load shed point handling to the ConnectionManager#44736
Open
birenroy wants to merge 7 commits into
Open
http2: Moves HTTP/2 GOAWAY load shed point handling to the ConnectionManager#44736birenroy wants to merge 7 commits into
birenroy wants to merge 7 commits into
Conversation
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/retest |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/assign @RyanTheOptimist |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/retest |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/assign @paul-r-gall |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
|
/retest |
RyanTheOptimist
previously approved these changes
May 11, 2026
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
This change LGTM, but I do wonder if it needs a runtime guard as this is a behavior change. I agree with your assessment that it's a bad idea to use the load shed point as-is, but someone might be doing so. WDYT?
Contributor
|
/wait |
Signed-off-by: Biren Roy <birenroy@google.com>
Contributor
Author
I added a runtime feature. Thanks! |
Signed-off-by: Biren Roy <birenroy@google.com>
RyanTheOptimist
approved these changes
May 14, 2026
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Thanks for adding the "just to be safe" runtime guard!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As implemented, the
http2_server_go_away_on_dispatchload shed point causes Envoy to send a singleGOAWAYframe, with themax_stream_idset to the highest stream ID observed by the server at that point. This results in the server dropping any requests in flight at that moment, making the load shed point unusable in practice.This PR moves the load shed point to the connection manager, where it can initiate the graceful shutdown sequence described in RFC 9113 Section 6.8, by calling
ConnectionManagerImpl::sendGoAwayAndClose().For symmetry, I have also moved the
http2_server_go_away_and_close_on_dispatchload shed point, maintaining the eager shutdown behavior.Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]