Improve ext_proc code coverage#44926
Conversation
|
/coverage |
|
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/44926/coverage/index.html For comparison, current coverage on https://storage.googleapis.com/envoy-cncf-postsubmit/main/coverage/index.html The coverage results are (re-)rendered each time the CI |
etruong42
force-pushed
the
extproccov
branch
2 times, most recently
from
e89daf0 to
71026e1
Compare
Signed-off-by: Ethan Truong <ethantruong@google.com>
etruong42
force-pushed
the
extproccov
branch
2 times, most recently
from
b64c310 to
75365e9
Compare
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
etruong42
requested review from
botengyao,
mattklein123,
tyxia,
yanavlasov and
yanjunxiang-google
as code owners
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
|
/assign yanjunxiang-google |
|
etruong42 is not allowed to assign users. |
|
/gemini review |
|
/assign yanjunxiang-google |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly enhances test coverage for the external processing filters across both HTTP and network implementations. It introduces accessor classes to facilitate testing of private members and adds several new test files and cases covering logging, response processing, and various edge cases such as timeouts and invalid headers. The review feedback highlights a logic error in a test case where a tautological assertion prevents proper verification of disallowed mode overrides.
Signed-off-by: Ethan Truong <ethantruong@google.com>
Signed-off-by: Ethan Truong <ethantruong@google.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the test coverage for the external processing (ext_proc) filters in both HTTP and network contexts. Key changes include the addition of accessor classes to facilitate testing of private members, new unit tests for logging info and response processors, and expanded test cases covering edge cases such as timeouts, error handling, and header mutations. Additionally, coverage thresholds in test/coverage.yaml have been updated to reflect these improvements. I have no feedback to provide as there were no review comments to assess.
|
pass to @yanjunxiang-google |
|
Please split the PR into two PRs with one for HTTP ext_proc, and one for network ext_proc as they are seperate filters. |
|
@yanjunxiang-google - I have split up this PR Network ext_proc PR: #45196 Thanks! |
4 participants
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]