Skip to content

server: rebuild AdminResponse FSM diagram and fix link.#45075

Open
jmarantz wants to merge 5 commits into
envoyproxy:mainfrom
jmarantz:fix-admin-response-drawing-link
Open

server: rebuild AdminResponse FSM diagram and fix link.#45075
jmarantz wants to merge 5 commits into
envoyproxy:mainfrom
jmarantz:fix-admin-response-drawing-link

Conversation

@jmarantz
Copy link
Copy Markdown
Contributor

Commit Message: When I wrote this class a couple of years ago I made a diagram describing the fininte state machine for life of an AdninResponse in a google drawing. For some reason that drawing disappeared so I re-created it (using AI).

This just fixes the link to point to the new diagram.
Additional Description: n/a
Risk Level: low (comment change)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Comment thread source/exe/admin_response.h Outdated
jmarantz added 3 commits May 14, 2026 22:24
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Copy Markdown
Contributor Author

good idea; will convert till draft till it is ready.

@jmarantz jmarantz marked this pull request as draft May 15, 2026 02:45
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz jmarantz marked this pull request as ready for review May 15, 2026 02:50
@jmarantz
Copy link
Copy Markdown
Contributor Author

Alright I guess this is OK now. I think I liked the old diagram better but it's nice not to have the code point into a google drawing I can accidentally delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants