Skip to content

clang tidy: part of fixes of test only code#45181

Merged
agrawroh merged 5 commits into
envoyproxy:mainfrom
wbpcode:dev-clang-tidy-tests-only
May 21, 2026
Merged

clang tidy: part of fixes of test only code#45181
agrawroh merged 5 commits into
envoyproxy:mainfrom
wbpcode:dev-clang-tidy-tests-only

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented May 20, 2026

Commit Message: clang tidy: part of fixes of test only code
Additional Description:

Test only clang tidy issue fixes. Not all because there are tooooooo much problems and even AI is not sound enough for that.

Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies a broad set of clang-tidy-driven cleanups across Envoy’s test-only code, aiming to reduce warnings and modernize patterns without changing production behavior.

Changes:

  • Refactors various test fixtures/utilities for clang-tidy compliance (initialization, overrides, loop style, naming).
  • Introduces a small test helper for intentionally out-of-range enum casts (uncheckedEnumCastForTest).
  • Updates benchmarks/tests to avoid undefined behavior patterns (e.g., PANIC, StrAppend, brace-init, etc.).

Reviewed changes

Copilot reviewed 180 out of 180 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/test_common/wasm_base.h Remove redundant {} member init
test/test_common/test_runtime.h Use THROW_IF_NOT_OK_REF
test/test_common/simulated_time_system.h Initialize atomic to 0
test/test_common/network_utility.h Remove redundant {} member init
test/test_common/logging.h Add NOLINT for naming
test/test_common/environment.cc Prefer .empty()
test/test_common/enum_test_utils.h Add helper for unsafe enum casts
test/test_common/BUILD Export new header + add Abseil dep
test/server/utils_test.cc Use enum test cast helper
test/server/connection_handler_test.cc Remove redundant {} member init
test/server/cgroup_cpu_util_test.cc Remove unused gtest usings
test/server/admin/stats_handler_speed_test.cc Use PANIC; rename benchmark
test/mocks/upstream/host.h Remove redundant {} member init
test/mocks/upstream/host.cc Use brace-init for OptRef
test/mocks/thread_local/mocks.h Add NOLINT for loop conversion
test/mocks/stats/mocks.h Add NOLINT for naming
test/mocks/ssl/mocks.h Remove redundant {} member init
test/mocks/server/hot_restart.cc Remove unused gtest using
test/mocks/server/health_checker_factory_context.h Remove redundant {} member init
test/mocks/network/mocks.h Remove redundant {} member init
test/integration/udp_tunneling_integration_test.cc Remove redundant {} member init
test/integration/tcp_proxy_integration_test.cc Add braces around loop
test/integration/ssl_utility.h Remove redundant {} member init
test/integration/quic_http_integration_test.cc Rename params-to-string fns
test/integration/overload_integration_test.cc Rename param + reflow signature
test/integration/listener_lds_integration_test.cc Remove redundant {} member init
test/integration/listener_extension_discovery_integration_test.cc Avoid copy in range-for
test/integration/filters/tee_filter.h Remove redundant {} member init
test/integration/filters/async_upstream_filter.cc Add override on dtor
test/integration/filter_manager_integration_test.cc Remove redundant {} member init
test/integration/fake_upstream.h Initialize atomic to 0
test/integration/cluster_filter_integration_test.cc Remove redundant {} member init
test/integration/base_integration_test.h Remove redundant {} member init
test/integration/async_round_robin_lb.cc Remove redundant virtual
test/integration/ads_integration.h Avoid calling param accessors in ctor init
test/integration/ads_integration_test.cc Default ctor
test/fuzz/fuzz_runner.cc Add include + NOLINT loop convert
test/extensions/upstreams/http/udp/config_test.cc Remove unused gtest using
test/extensions/upstreams/http/generic/config_test.cc Use enum test cast helper
test/extensions/transport_sockets/tls/cert_validator/spiffe/spiffe_validator_test.cc Prefer .empty(); remove redundant init
test/extensions/transport_sockets/alts/alts_channel_pool_test.cc Use <cstdlib>
test/extensions/tracers/opentelemetry/samplers/sampler_test.cc Remove redundant {} member init
test/extensions/tracers/opentelemetry/resource_detectors/static/static_config_resource_detector_integration_test.cc Prefer .empty()
test/extensions/tracers/opentelemetry/operation_name_test.cc Remove redundant {} member init
test/extensions/tracers/dynamic_modules/tracer_test.cc Remove unused gtest using
test/extensions/tracers/datadog/span_test.cc Rename accessor; brace-init tracer
test/extensions/tracers/datadog/agent_http_client_test.cc Use enum test cast helper
test/extensions/stats_sinks/open_telemetry/open_telemetry_impl_test.cc Add braces; remove redundant init
test/extensions/stats_sinks/open_telemetry/open_telemetry_benchmark.cc Rename benchmark functions
test/extensions/resource_monitors/cgroup_memory/config_test.cc Remove unused gtest using
test/extensions/rate_limit_descriptors/expr/config_test.cc Use THROW_IF_NOT_OK_REF
test/extensions/network/dns_resolver/benchmark/dns_resolver_benchmark.cc Rename benchmark functions
test/extensions/load_balancing_policies/common/load_balancer_impl_base_test.h NOLINT enum out-of-range
test/extensions/load_balancing_policies/client_side_weighted_round_robin/client_side_weighted_round_robin_lb_test.cc Add braces around if/else
test/extensions/key_value/file_based/key_value_store_test.cc Remove redundant {} member init
test/extensions/http/credential_injector/oauth2/credential_injector_oauth_integration_test.cc Remove redundant {} member init
test/extensions/grpc_credentials/file_based_metadata/integration_test.cc Remove redundant {} member init
test/extensions/filters/udp/dns_filter/dns_filter_access_log_test.cc Use brace-init return
test/extensions/filters/network/thrift_proxy/router_test.cc Remove redundant {} member init
test/extensions/filters/network/thrift_proxy/app_exception_impl_test.cc Add NOLINT for copy-init
test/extensions/filters/network/tcp_bandwidth_limit/filter_test.cc Use make_unique; add include
test/extensions/filters/network/reverse_tunnel/integration_test.cc Return {}
test/extensions/filters/network/reverse_tunnel/filter_unit_test.cc Modernize loops; simplify ctor
test/extensions/filters/network/redis_proxy/redis_proxy_integration_test.cc Use const ref alias
test/extensions/filters/network/rbac/filter_test.cc Default ctor
test/extensions/filters/network/http_connection_manager/config_test_base.h Create local config var
test/extensions/filters/network/http_connection_manager/config_filter_dependencies_test.cc Name local config instance
test/extensions/filters/network/generic_proxy/router/router_test.cc Remove redundant {} member init
test/extensions/filters/network/ext_proc/ext_proc_test.cc Remove unused gtest using
test/extensions/filters/network/ext_proc/ext_proc_integration_test.cc Range-for over filters
test/extensions/filters/network/ext_proc/config_test.cc Default ctor
test/extensions/filters/network/dubbo_proxy/router_test.cc Remove redundant {} member init
test/extensions/filters/network/dubbo_proxy/app_exception_test.cc Add NOLINT for copy-init
test/extensions/filters/listener/tls_inspector/tls_inspector_ja4_test.cc Remove unused gtest usings
test/extensions/filters/listener/tls_inspector/ja4_fingerprint_test.cc Remove unused gtest usings
test/extensions/filters/http/router/config_test.cc Use brace-init return
test/extensions/filters/http/rbac/rbac_filter_test.cc Remove redundant {} member init
test/extensions/filters/http/rate_limit_quota/integration_test.cc Add braces; remove redundant init
test/extensions/filters/http/rate_limit_quota/filter_persistence_test.cc Remove redundant init
test/extensions/filters/http/rate_limit_quota/client_test.cc Rename types; add braces; refactors
test/extensions/filters/http/rate_limit_quota/client_test_utils.h Range-for; add braces; remove redundant init
test/extensions/filters/http/proto_api_scrubber/filter_benchmark_test.cc Rename benchmarks; add braces
test/extensions/filters/http/on_demand/odcds_integration_test.cc Rename helper; simplify ctor
test/extensions/filters/http/oauth2/oauth_integration_test.cc NOLINT for return braced-init
test/extensions/filters/http/mcp/mcp_json_parser_test.cc Remove unused gtest usings
test/extensions/filters/http/grpc_field_extraction/message_converter/message_converter_test.cc Use std::ranges::reverse_view
test/extensions/filters/http/gcp_authn/gcp_authn_filter_integration_test.cc Remove redundant init
test/extensions/filters/http/file_server/absl_status_to_http_status_test.cc Enum helper include; adjust expectations
test/extensions/filters/http/ext_proc/streaming_integration_test.cc Remove redundant init
test/extensions/filters/http/ext_proc/http_client/http_client_test.cc Remove redundant init
test/extensions/filters/http/ext_proc/http_client/ext_proc_http_integration_test.cc Rename params-to-string; remove redundant init
test/extensions/filters/http/ext_proc/filter_test.cc Rename enum constants; update uses
test/extensions/filters/http/ext_proc/ext_proc_misc_test.cc Rename helper; remove redundant init
test/extensions/filters/http/ext_proc/ext_proc_misc_integration_test.cc Rename helper; remove redundant init
test/extensions/filters/http/ext_proc/ext_proc_integration_test.cc Use StrAppend
test/extensions/filters/http/ext_proc/ext_proc_integration_common.h NOLINT naming; remove redundant init
test/extensions/filters/http/ext_proc/ext_proc_integration_common.cc Use StrAppend
test/extensions/filters/http/ext_proc/ext_proc_grpc_fuzz.h Remove redundant init
test/extensions/filters/http/ext_proc/ext_proc_full_duplex_integration_test.cc Use StrAppend
test/extensions/filters/http/ext_proc/ext_proc_benchmark_test.cc Remove redundant init
test/extensions/filters/http/ext_authz/logging_test_filter.cc Rename helper; update call
test/extensions/filters/http/ext_authz/ext_authz_test.cc Default ctor; rename params-to-string
test/extensions/filters/http/ext_authz/ext_authz_integration_test.cc Remove redundant init
test/extensions/filters/http/ext_authz/ext_authz_fuzz_lib.cc Avoid proto copy
test/extensions/filters/http/dynamic_forward_proxy/test_resolver.h Add override on dtor
test/extensions/filters/http/dynamic_forward_proxy/proxy_filter_test.cc Remove redundant virtual
test/extensions/filters/http/decompressor/decompressor_filter_integration_test.cc Remove redundant init
test/extensions/filters/http/common/mock.cc Prefer .empty()
test/extensions/filters/http/common/fuzz/uber_filter.h Remove redundant init
test/extensions/filters/http/cache/cache_filter_logging_info_test.cc Use enum test cast helper
test/extensions/filters/http/cache/cache_entry_utils_test.cc Use enum test cast helper
test/extensions/filters/http/cache_v2/http_cache_implementation_test_common.cc Remove unused usings
test/extensions/filters/http/cache_v2/config_test.cc Compact string return
test/extensions/filters/http/cache_v2/cache_entry_utils_test.cc Use enum test cast helper
test/extensions/filters/http/bandwidth_share/fair_token_bucket_impl_test.cc Add override; modernize loops
test/extensions/filters/common/ext_authz/ext_authz_grpc_impl_test.cc Use {} for optional unset
test/extensions/filters/common/expr/evaluator_test.cc Remove unused gtest using
test/extensions/dynamic_modules/listener/abi_impl_test.cc Brace-init IoCall result
test/extensions/config_subscription/grpc/sotw_subscription_state_test.cc Use enum test cast helper
test/extensions/config_subscription/grpc/new_grpc_mux_impl_test.cc Remove redundant init
test/extensions/compression/zstd/decompressor/zstd_decompressor_impl_test.cc Remove redundant init
test/extensions/compression/gzip/decompressor/zlib_decompressor_impl_test.cc Remove redundant init
test/extensions/common/wasm/test_data/test_cpp.cc Use enum test cast helper
test/extensions/common/redis/cluster_refresh_manager_test.cc Remove redundant init (atomics)
test/extensions/common/dynamic_forward_proxy/dns_cache_impl_test.cc Prefer if (ptr)
test/extensions/common/dubbo/codec_test.cc Use enum test cast helper
test/extensions/common/aws/eventstream/eventstream_parser_test.cc Add braces; NOLINT return init
test/extensions/common/aws/credential_providers/iam_roles_anywhere_credentials_provider_test.cc Prefer .empty()
test/extensions/clusters/redis/redis_cluster_lb_test.cc Avoid move of shared_ptr
test/extensions/clusters/composite/cluster_test.cc Use THROW_IF_NOT_OK_REF
test/extensions/clusters/common/logical_host_integration_test.cc Rename Address struct
test/extensions/bootstrap/wasm/wasm_test.cc Remove redundant init
test/extensions/bootstrap/wasm/test_data/speed_cpp.cc Prefer .empty()
test/extensions/bootstrap/reverse_tunnel/upstream_socket_interface/reverse_tunnel_acceptor_extension_test.cc Use make_unique
test/extensions/bootstrap/reverse_tunnel/downstream_socket_interface/reverse_connection_resolver_test.cc Remove unused gtest usings
test/extensions/bootstrap/reverse_tunnel/downstream_socket_interface/reverse_connection_io_handle_test.cc Prefer .empty()
test/extensions/bootstrap/reverse_tunnel/downstream_socket_interface/reverse_connection_address_test.cc Brace-init return; NOLINT copy-init
test/extensions/bootstrap/reverse_tunnel/downstream_socket_interface/rc_connection_wrapper_test.cc Prefer .empty()
test/extensions/access_loggers/stats/stats_test.cc Add braces
test/extensions/access_loggers/stats/stats_speed_test.cc Add braces; rename benchmarks
test/extensions/access_loggers/open_telemetry/otlp_log_utils_test.cc Remove unused gtest using
test/extensions/access_loggers/fluentd/fluentd_access_log_impl_test.cc NOLINT return init
test/common/upstream/transport_socket_input_test.cc Remove unused gtest using
test/common/upstream/health_checker_impl_test.cc Remove redundant init
test/common/upstream/health_check_fuzz_test_utils.h Remove redundant init
test/common/tls/test_private_key_method_provider.h Remove redundant init
test/common/tls/integration/ssl_integration_test_base.h NOLINT naming
test/common/tls/cert_validator/test_common.h Remove redundant init
test/common/tcp/conn_pool_test.cc Remove redundant init
test/common/tcp/async_tcp_client_impl_test.cc Add override on dtor
test/common/tcp_proxy/tcp_proxy_test.cc Use char literals
test/common/tcp_proxy/tcp_proxy_test_base.h Remove redundant init
test/common/stats/refcount_ptr_test.cc Fix shared_ptr copy
test/common/runtime/runtime_impl_test.cc Use THROW_IF_NOT_OK_REF
test/common/quic/quic_stat_names_test.cc Use enum test cast helper
test/common/quic/envoy_quic_proof_verifier_test.cc Use THROW_IF_NOT_OK_REF
test/common/quic/envoy_quic_proof_source_test.cc Use THROW_IF_NOT_OK_REF
test/common/quic/envoy_quic_h3_fuzz_test.cc Remove redundant init
test/common/network/udp_listener_impl_test.cc Use StrAppend
test/common/network/udp_listener_impl_batch_writer_test.cc Prefer .empty()
test/common/network/lc_trie_ip_list_speed_test.cc Rename benchmarks; add DoNotOptimize
test/common/network/io_socket_handle_impl_benchmark_test.cc Rename benchmarks; add DoNotOptimize
test/common/network/connection_impl_test.cc Simplify ctor
test/common/network/address_impl_test.cc Use brace-init return
test/common/jwt/verify_jwk_rsa_test.cc Add override on SetUp
test/common/jwt/verify_jwk_rsa_pss_test.cc Add override on SetUp
test/common/jwt/verify_jwk_okp_test.cc Add override on SetUp
test/common/jwt/verify_jwk_hmac_test.cc Add override on SetUp
test/common/jwt/verify_jwk_ec_test.cc Add override on SetUp
test/common/jwt/simple_lru_cache_test.cc Modernize ownership/loops; rename helper
test/common/jwt/jwt_test.cc Range-for over references
test/common/json/json_rpc_field_extractor_test.cc Avoid virtual call in ctor
test/common/io/io_uring_worker_factory_impl_test.cc Remove redundant init
test/common/io/io_uring_impl_test.cc Remove redundant init
test/common/http/session_idle_list_test.cc Rename accessor; add override
test/common/http/http_server_properties_cache_impl_test.cc Fix paramization/ownership
test/common/http/codes_test.cc Use enum test cast helper
test/common/common/linked_object_speed_test.cc Add DoNotOptimize
test/common/buffer/watermark_buffer_test.cc Use string overload
test/common/buffer/buffer_test.cc Reserve vector capacity

Comment thread test/extensions/filters/http/rate_limit_quota/client_test.cc
Comment thread test/extensions/common/redis/cluster_refresh_manager_test.cc
Comment on lines 19 to 22

#include "test/test_common/enum_test_utils.h"

START_WASM_PLUGIN(CommonWasmTestCpp)
Comment thread test/fuzz/fuzz_runner.cc
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
mathetake
mathetake previously approved these changes May 20, 2026
tyxia
tyxia previously approved these changes May 20, 2026
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
@wbpcode wbpcode dismissed stale reviews from tyxia and mathetake via 5945be7 May 21, 2026 03:56
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
@agrawroh agrawroh merged commit a6e2643 into envoyproxy:main May 21, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants