Enhance Kafka example with consumer groups and admin operations coverage#1017
Closed
Copilot wants to merge 5 commits into
Closed
Enhance Kafka example with consumer groups and admin operations coverage#1017Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
…tions, and topic deletion Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enhance Kafka example with comprehensive integration test coverage
Enhance Kafka example with consumer groups and admin operations coverage
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands Kafka broker filter integration testing to cover consumer group coordination, topic configuration management, partition operations, and topic deletion. Migrates test coverage from
envoyproxy/envoyrepository.Changes
Documentation (
kafka/example.rst)find_coordinator,join_group,sync_group,leave_grouprequest/response metrics)Integration Tests (
kafka/verify.sh)Technical Notes
Uses
incremental_alter_configs_requestmetric rather thanalter_configs_request- newer Kafka versions (including the one in this example) use the incremental API for configuration changes.Example metric validation:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
2.0.18.172.in-addr.arpa/usr/bin/java java -cp /usr/share/java/cp-base-new/* -Dlog4j.configuration=file:/etc/kafka/log4j.properties io.confluent.admin.utils.cli.ZookeeperReadyCommand zookeeper:2181 40000 /opt/containerd/bin/bash /run/containerd//usr/sbin/iptables --log-format json 635/log.json ocke�� y /var/run/docker/-s ntime.v2.task/mo127.0.0.11 /run/containerd//usr/sbin/iptables --log-format json a33852097bc08fd2nat(dns block)3.0.18.172.in-addr.arpa/usr/bin/java java -cp /usr/share/java/cp-base-new/* -Dlog4j.configuration=file:/etc/kafka/log4j.properties io.confluent.admin.utils.cli.ZookeeperReadyCommand zookeeper:2181 40000(dns block)/usr/bin/java java -cp /usr/share/java/cp-base-new/* -Dlog4j.configuration=file:/etc/kafka/log4j.properties io.confluent.admin.utils.cli.ZookeeperReadyCommand zookeeper:2181 40000 /usr/bin/gpgv ntime.v2.task/mo/usr/sbin/iptables(dns block)kafka-server/usr/local/bin/envoy /usr/local/bin/envoy -c /etc/envoy.yaml(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Summary
Enhance the existing
kafkaexample to provide more comprehensive integration test coverage for the Kafka broker filter.This is part of migrating Kafka integration test coverage from
envoyproxy/envoyto the examples repo. See: envoyproxy/envoy#43182Current coverage
The existing example tests:
api_versions,metadata,create_topics,produce,fetch)Gaps to fill
The Python integration tests in envoy (
kafka_broker_integration_test.py) also test:Consumer groups - multiple consumers forming a group, which exercises:
find_coordinator_request/responsejoin_group_request/responsesync_group_request/responseleave_group_request/responseAdditional admin operations:
alter_configs(change topic config)create_partitions(add partitions to topic)delete_topicsHigher volume - produce/consume multiple messages
Changes to
kafka/example.rstAdd new steps after the existing ones:
Changes to
kafka/verify.shAdd tests for the new functionality after the existing tests. The verify.sh should test what the docs describe: