Skip to content

BUILD: Exclude kafka-mesh/*.yaml from main configs filegroup#1028

Merged
phlax merged 2 commits into
mainfrom
copilot/fix-kafka-mesh-config-exclusion
Jan 28, 2026
Merged

BUILD: Exclude kafka-mesh/*.yaml from main configs filegroup#1028
phlax merged 2 commits into
mainfrom
copilot/fix-kafka-mesh-config-exclusion

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 27, 2026

The kafka-mesh/*.yaml configs use envoy.filters.network.kafka_mesh (contrib extension) but were missing from the exclude list in the configs filegroup, causing non-contrib validation tests to fail.

Changes

  • Added "kafka-mesh/*.yaml" to the exclude list in configs filegroup (BUILD:69)

This aligns with the existing pattern for other contrib extensions (kafka/*.yaml, golang-http/*.yaml, mysql/*, postgres/*), which are excluded from configs and included only in contrib_configs.

filegroup(
    name = "configs",
    exclude = [
        # ...
        "kafka/*.yaml",
        "kafka-mesh/*.yaml",  # Added
    ],
)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • releases.bazel.build
    • Triggering command: /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 /usr/local/lib/node_modules/@bazel/bazelisk/bazelisk-linux_amd64 version (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Problem

The kafka-mesh/*.yaml configs are included in the contrib_configs filegroup (correct), but they are not excluded from the main configs filegroup. This causes Envoy's non-contrib config validation test to fail when trying to validate kafka-mesh/envoy.yaml, which uses the envoy.filters.network.kafka_mesh contrib extension.

The kafka/*.yaml configs are properly excluded from configs and included in contrib_configs, but kafka-mesh/*.yaml was missed.

Location

File: BUILD (root of repository)

Current state

In the configs filegroup, the exclude list includes:

exclude = [
    # ...
    # Contrib extensions tested over in contrib.
    "golang-http/*.yaml",
    "golang-network/*.yaml", 
    "mysql/*",
    "postgres/*",
    "kafka/*.yaml",
    # kafka-mesh/*.yaml is MISSING from exclude list
],

But kafka-mesh/*.yaml is in the contrib_configs filegroup:

filegroup(
    name = "contrib_configs",
    srcs = glob(
        [
            "golang-http/*.yaml",
            "golang-network/*.yaml",
            "mysql/*.yaml",
            "postgres/*.yaml",
            "kafka/*.yaml",
            "kafka-mesh/*.yaml",  # This is here
        ],
        ...
    ),
)

Fix

Add kafka-mesh/*.yaml to the exclude list in the configs filegroup:

exclude = [
    # ...
    # Contrib extensions tested over in contrib.
    "golang-http/*.yaml",
    "golang-network/*.yaml",
    "mysql/*",
    "postgres/*",
    "kafka/*.yaml",
    "kafka-mesh/*.yaml",  # Add this line
],

This ensures kafka-mesh/envoy.yaml is only validated by the contrib config test (which has the kafka_mesh extension available), not by the standard config validation test.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

kafka-mesh configs use contrib extensions (envoy.filters.network.kafka_mesh)
and should only be validated by contrib config tests, not standard tests.

Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix kafka-mesh configs exclusion from main filegroup BUILD: Exclude kafka-mesh/*.yaml from main configs filegroup Jan 27, 2026
Copilot AI requested a review from phlax January 27, 2026 23:48
@phlax phlax marked this pull request as ready for review January 28, 2026 09:03
@phlax phlax merged commit 2abca90 into main Jan 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants