Skip to content

Commit 15ff876

Browse files
committed
review update
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
1 parent 80dece9 commit 15ff876

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

charts/gateway-helm/templates/_rbac.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ verbs:
249249
- watch
250250
{{- end }}
251251

252-
{{- define "eg.rbac.namespaced.infra.secrets.read" -}}
252+
{{- define "eg.rbac.controllernamespace.secrets.read" -}}
253253
- apiGroups:
254254
- ""
255255
resources:

charts/gateway-helm/templates/infra-manager-rbac.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ metadata:
4343
rules:
4444
{{ include "eg.rbac.infra.basic" . }}
4545
{{ if and (.Values.config.envoyGateway.provider.kubernetes) (.Values.config.envoyGateway.provider.kubernetes.watch) (.Values.config.envoyGateway.provider.kubernetes.deploy) (eq .Values.config.envoyGateway.provider.kubernetes.deploy.type "GatewayNamespace") (.Values.config.envoyGateway.provider.kubernetes.watch.namespaces) (gt (len .Values.config.envoyGateway.provider.kubernetes.watch.namespaces) 0) }}
46-
{{ include "eg.rbac.namespaced.infra.secrets.read" . }}
46+
{{ include "eg.rbac.controllernamespace.secrets.read" . }}
4747
{{ end }}
4848
---
4949
apiVersion: rbac.authorization.k8s.io/v1

release-notes/current.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,9 @@ bug fixes: |
6868
Fixed per-endpoint hostname override not working because the auto-generated wildcard hostname.
6969
Fixed Basic Authentication failing when htpasswd secrets use CRLF line endings by normalizing to LF before passing to Envoy.
7070
BackendTLSPolicy was ignored when configuring TLS for telemetry backends (access logs, tracing, metrics).
71-
<<<<<<< HEAD
7271
Fixed client certificate secret never delivered when it is exclusively referenced by a SecurityPolicy `extAuth`/`jwt`/`oidc` Backend
7372
Fixed xRoute status condition when route has mirror filter and the mirror backend has no endpoints.
74-
=======
75-
Fixed gateway-helm RBAC in GatewayNamespace mode with explicit `watch.namespaces` list by adding controller-namespace secret read permissions to infra-manager so generated certs ConfigMaps include `ca.crt`; secret read access is scoped to the `gateway-helm-infra-manager` Role for this mode.
76-
>>>>>>> 0d0455f71 (add release notes)
73+
Fixed gateway-helm RBAC in GatewayNamespace mode with explicit `watch.namespaces` list by adding controller-namespace secret read permissions to infra-manager.
7774
7875
# Enhancements that improve performance.
7976
performance improvements: |

0 commit comments

Comments
 (0)