You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your PR title should be descriptive, and generally start with type that contains a subsystem name with `()` if necessary
4
-
and summary followed by a colon. format `chore/docs/api/feat/fix/refactor/style/test: summary`.
2
+
Your PR title should be descriptive, and generally start with a type that contains a subsystem name with `()` if necessary
3
+
and a summary followed by a colon. format `chore/docs/api/feat/fix/refactor/style/test: summary`.
5
4
Examples:
6
5
* "docs: fix grammar error"
7
6
* "feat(translator): add new feature"
8
7
* "fix: fix xx bug"
9
8
* "chore: change ci & build tools etc"
10
9
* "api: add xxx fields in ClientTrafficPolicy"
11
-
12
-
Before raising a PR, please go through this section of the developer guide, https://gateway.envoyproxy.io/community/develop/#raising-a-pr
13
10
-->
14
11
15
12
<!--
16
-
NOTE: If your PR contains any API changes (changes under `/api`), we recommend you to separate these API changes into
17
-
a new PR, and we will review the API part first. It will save you lots of implementation time if the API get accepted.
13
+
NOTE: If your PR contains any API changes (changes under `/api`), the API must be discussed and
14
+
agreed before the implementation. We strongly recommend separating API changes into their own PR so
15
+
we can review the API first, but the API may also live in the same PR as long as it was agreed
16
+
beforehand. This will save you a lot of implementation time if the API gets accepted.
18
17
-->
19
18
20
19
**What this PR does / why we need it**:
20
+
<!--
21
+
Briefly describe what this PR changes and the motivation behind it. Include enough context for a
22
+
reviewer to understand the problem being solved and the approach taken, e.g. what behavior changes,
23
+
any alternatives considered, and anything reviewers should pay special attention to.
24
+
-->
21
25
22
26
**Which issue(s) this PR fixes**:
23
27
<!--
@@ -26,9 +30,23 @@ Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
26
30
-->
27
31
Fixes #
28
32
33
+
---
34
+
35
+
**PR Checklist**
29
36
<!--
30
-
For any non-trivial changes, you need to provide a brief description of the changes in the release notes.
31
-
Please add a new fragment file under release-notes/current/<section>/<pr-number>-<slug>.md and include it in the PR.
32
-
See release-notes/current/README.md for the available sections and the naming convention.
37
+
Please tick the boxes below before requesting a review. PRs that leave required items unchecked may
38
+
be delayed or closed. Replace `[ ]` with `[x]` to check a box. If an item does not apply, check it
39
+
and add "N/A: <reason>".
33
40
-->
34
-
Release Notes: Yes/No
41
+
42
+
-[ ]**Authorship & ownership**: Coding agents / AI assistants are welcome, but I have reviewed every change, understand how and why it works, can explain and maintain it, and take full responsibility for this PR. I have not submitted generated output I do not understand.
43
+
-[ ]**DCO**: All commits are signed off (`git commit -s`). See [DCO: Sign your work](https://gateway.envoyproxy.io/community/contributing/#dco-sign-your-work).
44
+
-[ ]**API agreed first**: If this PR contains API changes (changes under `/api`), the API was discussed and agreed **before** the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.
45
+
-[ ]**Required checks pass**: `make generate gen-check`, `make lint`, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, but `gen-check`, `lint`, and coverage **MUST** pass.)
46
+
-[ ]**Tests added/updated**: New/changed code is covered by appropriate tests. N/A if this PR does not contain code changes.
47
+
-[ ]**Docs**: User-facing changes update the [docs](https://github.com/envoyproxy/gateway/tree/main/site), either in this PR or a follow-up PR. N/A if this PR does not contain user-facing changes.
48
+
-[ ]**Release notes**: For any non-trivial change, added a release-note fragment under `release-notes/current/<section>/<pr-number>-<slug>.md` (see `release-notes/current/README.md` for sections and naming). N/A if this PR does not contain non-trivial changes.
49
+
-[ ]**Generated files committed**: Ran `make gen-check` and committed the result if API/helm charts/modules changed.
50
+
-[ ]**Scope & compatibility**: The PR is reasonably scoped (no unrelated changes) and preserves backward compatibility, or any breaking change is called out above and documented in `release-notes/current/breaking_changes/`.
51
+
-[ ]**Codex review**: Requested a Codex review and addressed all of its comments.
52
+
-[ ]**Copilot review**: Requested a Copilot review and addressed all of its comments.
0 commit comments