fix ListenerSetHostnameConflict

Signed-off-by: zirain <zirain2009@gmail.com>

Author: zirain

internal/gatewayapi/listener.go

@@ -105,7 +105,7 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR resource
 			t.validateHostName(listener)
 
 			// Process conditions and check if the listener is ready
-			t.validateListenerConditions(listener)
+			listenerValid := t.validateListenerConditions(listener)
 
 			address := netutils.IPv4ListenerAddress
 			ipFamily := getEnvoyIPFamily(gateway.envoyProxy)
@@ -123,7 +123,7 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR resource
 				continue
 			}
 
-			if listener.isFromListenerSet() {
+			if listener.isFromListenerSet() && listenerValid {
 				lsKey := types.NamespacedName{
 					Namespace: listener.listenerSet.Namespace,
 					Name:      listener.listenerSet.Name,

internal/gatewayapi/testdata/listenerset-hostname-conflict.out.yaml

@@ -25,7 +25,7 @@ gateways:
       port: 80
       protocol: HTTP
   status:
-    attachedListenerSets: 4
+    attachedListenerSets: 2
     listeners:
     - attachedRoutes: 0
       conditions:

internal/gatewayapi/testdata/listenerset-https-tls-misuses-gateway-namespace.out.yaml

@@ -20,7 +20,6 @@ gateways:
       port: 80
       protocol: HTTP
   status:
-    attachedListenerSets: 1
     listeners:
     - attachedRoutes: 0
       conditions:

internal/gatewayapi/testdata/listenerset-invalid.out.yaml

@@ -20,7 +20,7 @@ gateways:
       port: 80
       protocol: HTTP
   status:
-    attachedListenerSets: 2
+    attachedListenerSets: 1
     listeners:
     - attachedRoutes: 0
       conditions:

internal/gatewayapi/validate.go

@@ -274,7 +274,7 @@ func (t *Translator) validateBackendRefBackend(
 	return nil
 }
 
-func (t *Translator) validateListenerConditions(listener *ListenerContext) {
+func (t *Translator) validateListenerConditions(listener *ListenerContext) bool {
 	lConditions := listener.GetConditions()
 	if len(lConditions) == 0 {
 		listener.SetCondition(gwapiv1.ListenerConditionProgrammed, metav1.ConditionTrue, gwapiv1.ListenerReasonProgrammed,
@@ -285,7 +285,7 @@ func (t *Translator) validateListenerConditions(listener *ListenerContext) {
 			"Listener references have been resolved")
 		listener.SetCondition(gwapiv1.ListenerConditionConflicted, metav1.ConditionFalse, gwapiv1.ListenerReasonNoConflicts,
 			"No conflicts detected")
-		return
+		return true
 	}
 
 	// Edge case: only one condition which is ResolvedRefs=False, Reason=PartiallyInvalidCertificateRef
@@ -296,7 +296,7 @@ func (t *Translator) validateListenerConditions(listener *ListenerContext) {
 			"Listener has been successfully translated")
 		listener.SetCondition(gwapiv1.ListenerConditionProgrammed, metav1.ConditionTrue, gwapiv1.ListenerReasonProgrammed,
 			"Sending translated listener configuration to the data plane")
-		return
+		return true
 	}
 
 	// Any condition on the listener apart from Programmed=true indicates an error.
@@ -332,8 +332,10 @@ func (t *Translator) validateListenerConditions(listener *ListenerContext) {
 			)
 		}
 		// skip computing IR
-		return
+		return false
 	}
+
+	return true
 }
 
 func (t *Translator) validateAllowedNamespaces(listener *ListenerContext) {