fix empty resource metadata for service

Signed-off-by: Teo Zhuo Yang <zteo@moneylion.com>

Author: zhuoyang

internal/gatewayapi/listener_test.go

@@ -1395,7 +1395,7 @@ func TestProcessBackendRefsBackendTLSPolicy(t *testing.T) {
 		},
 	}
 	serviceEndpoints := []*ir.DestinationEndpoint{{Host: "7.7.7.7", Port: 4317}}
-	serviceMetadata := &ir.ResourceMetadata{Name: serviceName, Namespace: ns, SectionName: "4317"}
+	serviceMetadata := &ir.ResourceMetadata{Kind: resource.KindService, Name: serviceName, Namespace: ns, SectionName: "4317"}
 	servicePolicyTLS := &ir.TLSUpstreamConfig{
 		SNI: ptr.To("otel-svc.example.com"), UseSystemTrustStore: true,
 		CACertificate: &ir.TLSCACertificate{Name: "otel-svc-tls/test-ns-ca"}, SubjectAltNames: []ir.SubjectAltName{},

internal/gatewayapi/route.go

@@ -1313,12 +1313,17 @@ func (t *Translator) processHTTPRouteParentRefListener(route RouteContext, route
 	return hasHostnameIntersection
 }
 
-func buildResourceMetadata(resource client.Object, sectionName *gwapiv1.SectionName) *ir.ResourceMetadata {
+func buildResourceMetadata(obj client.Object, sectionName *gwapiv1.SectionName) *ir.ResourceMetadata {
+	kind := obj.GetObjectKind().GroupVersionKind().Kind
+	if _, ok := obj.(*corev1.Service); ok && kind == "" {
+		kind = resource.KindService
+	}
+
 	metadata := &ir.ResourceMetadata{
-		Kind:        resource.GetObjectKind().GroupVersionKind().Kind,
-		Name:        resource.GetName(),
-		Namespace:   resource.GetNamespace(),
-		Annotations: ir.MapToSlice(filterEGPrefix(resource.GetAnnotations())),
+		Kind:        kind,
+		Name:        obj.GetName(),
+		Namespace:   obj.GetNamespace(),
+		Annotations: ir.MapToSlice(filterEGPrefix(obj.GetAnnotations())),
 	}
 	if sectionName != nil {
 		metadata.SectionName = string(*sectionName)
@@ -1997,7 +2002,7 @@ func (t *Translator) applyServiceBackendHostname(setting *ir.DestinationSetting)
 		return
 	}
 
-	if setting.Metadata.Kind != "" { // if the kind is not empty, it means the destination setting is not a service
+	if setting.Metadata.Kind != resource.KindService {
 		return
 	}
 	if setting.Metadata.Name == "" || setting.Metadata.Namespace == "" {

internal/gatewayapi/route_test.go

@@ -451,11 +451,22 @@ func TestIsServiceHeadless(t *testing.T) {
 }
 
 func TestApplyServiceBackendHostname(t *testing.T) {
+	t.Run("build metadata infers service kind from typed object", func(t *testing.T) {
+		service := &corev1.Service{ObjectMeta: metav1.ObjectMeta{Name: "service-1", Namespace: "default"}}
+
+		metadata := buildResourceMetadata(service, ptr.To(gwapiv1.SectionName("8080")))
+
+		require.Equal(t, resource.KindService, metadata.Kind)
+		require.Equal(t, "service-1", metadata.Name)
+		require.Equal(t, "default", metadata.Namespace)
+		require.Equal(t, "8080", metadata.SectionName)
+	})
 
 	t.Run("uses default cluster domain", func(t *testing.T) {
 		translator := &Translator{}
 		setting := &ir.DestinationSetting{
 			Metadata: &ir.ResourceMetadata{
+				Kind:      resource.KindService,
 				Name:      "service-1",
 				Namespace: "default",
 			},
@@ -471,6 +482,7 @@ func TestApplyServiceBackendHostname(t *testing.T) {
 		translator := &Translator{DNSDomain: "example.internal"}
 		setting := &ir.DestinationSetting{
 			Metadata: &ir.ResourceMetadata{
+				Kind:      resource.KindService,
 				Name:      "service-1",
 				Namespace: "default",
 			},