fix: address code review comment

dmavrodiev · dmavrodiev · commit 8a37916be8d0 · 2026-07-13T10:22:22.000+03:00
Link the SANs RFC section in the comments.

Signed-off-by: Dimitar Mavrodiev &lt;dmavrodiev@gmail.com&gt;
diff --git a/internal/gatewayapi/tls.go b/internal/gatewayapi/tls.go
@@ -125,6 +125,8 @@ func parseCertsFromTLSSecretsData(secrets []*corev1.Secret) ([]*corev1.Secret, [
 		}
 
 		// Check uniqueness for each domain in the certificate with this algorithm
+		// Dedupe SANs within this single cert first - RFC 5280 4.2.1.6 permits
+		// repeated entries in a GeneralNames sequence
 		seenDomains := sets.New[string]()
 		hasConflictDomainAlgorithm := false
 		for _, domain := range certDomains {

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,8 @@ func parseCertsFromTLSSecretsData(secrets []corev1.Secret) ([]corev1.Secret, [`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`// Check uniqueness for each domain in the certificate with this algorithm`
	`128`	`+ // Dedupe SANs within this single cert first - RFC 5280 4.2.1.6 permits`
	`129`	`+ // repeated entries in a GeneralNames sequence`
`128`	`130`	`seenDomains := sets.New[string]()`
`129`	`131`	`hasConflictDomainAlgorithm := false`
`130`	`132`	`for _, domain := range certDomains {`