Skip to content

Commit 9d919e5

Browse files
felipesabadinijukie
felipesabadini
and
jukie
authored
fix: correct duration dashboard panels to use proper PromQL queries (#8528)
* fix: correct duration dashboard panels to use proper PromQL queries The duration panels for status_update, resource_apply, and resource_delete metrics were showing cumulative _sum counter values instead of actual durations. - Avg panels: use rate(sum)/rate(count) for true average duration - Rename Max panels to p99: use histogram_quantile(0.99, rate(bucket)) - Rename Min panels to p50: use histogram_quantile(0.50, rate(bucket)) - All panels: use sum by(kind) for consistent grouping and lastNotNull calc Fixes #8439 Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> * Update default.out.yaml Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> * Update e2e.out.yaml Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> --------- Signed-off-by: Felipe Sabadini Facina <fsabadini@hotmail.com> Signed-off-by: Isaac Wilson <isaac.wilson514@gmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com>
1 parent 7b14b5b commit 9d919e5

3 files changed

Lines changed: 90 additions & 90 deletions

File tree

‎charts/gateway-addons-helm/dashboards/envoy-gateway-global.json‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@
603603
"orientation": "vertical",
604604
"reduceOptions": {
605605
"calcs": [
606-
"mean"
606+
"lastNotNull"
607607
],
608608
"fields": "",
609609
"values": false
@@ -620,8 +620,8 @@
620620
"uid": "$datasource"
621621
},
622622
"disableTextWrap": false,
623-
"editorMode": "builder",
624-
"expr": "status_update_duration_seconds_sum{namespace=\"$Namespace\"}",
623+
"editorMode": "code",
624+
"expr": "sum by(kind) (rate(status_update_duration_seconds_sum{namespace=\"$Namespace\"}[5m])) / sum by(kind) (rate(status_update_duration_seconds_count{namespace=\"$Namespace\"}[5m]))",
625625
"format": "time_series",
626626
"fullMetaSearch": false,
627627
"includeNullMetadata": true,
@@ -685,7 +685,7 @@
685685
"orientation": "vertical",
686686
"reduceOptions": {
687687
"calcs": [
688-
"max"
688+
"lastNotNull"
689689
],
690690
"fields": "",
691691
"values": false
@@ -702,8 +702,8 @@
702702
"uid": "$datasource"
703703
},
704704
"disableTextWrap": false,
705-
"editorMode": "builder",
706-
"expr": "status_update_duration_seconds_sum{namespace=\"$Namespace\"}",
705+
"editorMode": "code",
706+
"expr": "histogram_quantile(0.99, sum by(le, kind) (rate(status_update_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
707707
"format": "time_series",
708708
"fullMetaSearch": false,
709709
"includeNullMetadata": true,
@@ -714,7 +714,7 @@
714714
"useBackend": false
715715
}
716716
],
717-
"title": "Max Duration",
717+
"title": "p99 Duration",
718718
"type": "bargauge"
719719
},
720720
{
@@ -767,7 +767,7 @@
767767
"orientation": "vertical",
768768
"reduceOptions": {
769769
"calcs": [
770-
"logmin"
770+
"lastNotNull"
771771
],
772772
"fields": "",
773773
"values": false
@@ -784,8 +784,8 @@
784784
"uid": "$datasource"
785785
},
786786
"disableTextWrap": false,
787-
"editorMode": "builder",
788-
"expr": "status_update_duration_seconds_sum{namespace=\"$Namespace\"}",
787+
"editorMode": "code",
788+
"expr": "histogram_quantile(0.50, sum by(le, kind) (rate(status_update_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
789789
"format": "time_series",
790790
"fullMetaSearch": false,
791791
"includeNullMetadata": true,
@@ -796,7 +796,7 @@
796796
"useBackend": false
797797
}
798798
],
799-
"title": "Min Duration",
799+
"title": "p50 Duration",
800800
"type": "bargauge"
801801
},
802802
{
@@ -1656,7 +1656,7 @@
16561656
"orientation": "auto",
16571657
"reduceOptions": {
16581658
"calcs": [
1659-
"mean"
1659+
"lastNotNull"
16601660
],
16611661
"fields": "",
16621662
"values": false
@@ -1673,8 +1673,8 @@
16731673
"uid": "$datasource"
16741674
},
16751675
"disableTextWrap": false,
1676-
"editorMode": "builder",
1677-
"expr": "sum by(kind) (resource_apply_duration_seconds_sum{namespace=\"$Namespace\"})",
1676+
"editorMode": "code",
1677+
"expr": "sum by(kind) (rate(resource_apply_duration_seconds_sum{namespace=\"$Namespace\"}[5m])) / sum by(kind) (rate(resource_apply_duration_seconds_count{namespace=\"$Namespace\"}[5m]))",
16781678
"fullMetaSearch": false,
16791679
"includeNullMetadata": true,
16801680
"instant": false,
@@ -1735,7 +1735,7 @@
17351735
"orientation": "auto",
17361736
"reduceOptions": {
17371737
"calcs": [
1738-
"max"
1738+
"lastNotNull"
17391739
],
17401740
"fields": "",
17411741
"values": false
@@ -1752,8 +1752,8 @@
17521752
"uid": "$datasource"
17531753
},
17541754
"disableTextWrap": false,
1755-
"editorMode": "builder",
1756-
"expr": "sum by(kind) (resource_apply_duration_seconds_sum{namespace=\"$Namespace\"})",
1755+
"editorMode": "code",
1756+
"expr": "histogram_quantile(0.99, sum by(le, kind) (rate(resource_apply_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
17571757
"fullMetaSearch": false,
17581758
"includeNullMetadata": true,
17591759
"instant": false,
@@ -1763,7 +1763,7 @@
17631763
"useBackend": false
17641764
}
17651765
],
1766-
"title": "Max Apply Duration",
1766+
"title": "p99 Apply Duration",
17671767
"type": "bargauge"
17681768
},
17691769
{
@@ -1814,7 +1814,7 @@
18141814
"orientation": "auto",
18151815
"reduceOptions": {
18161816
"calcs": [
1817-
"logmin"
1817+
"lastNotNull"
18181818
],
18191819
"fields": "",
18201820
"values": false
@@ -1831,8 +1831,8 @@
18311831
"uid": "$datasource"
18321832
},
18331833
"disableTextWrap": false,
1834-
"editorMode": "builder",
1835-
"expr": "sum by(kind) (resource_apply_duration_seconds_sum{namespace=\"$Namespace\"})",
1834+
"editorMode": "code",
1835+
"expr": "histogram_quantile(0.50, sum by(le, kind) (rate(resource_apply_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
18361836
"fullMetaSearch": false,
18371837
"includeNullMetadata": true,
18381838
"instant": false,
@@ -1842,7 +1842,7 @@
18421842
"useBackend": false
18431843
}
18441844
],
1845-
"title": "Min Apply Duration",
1845+
"title": "p50 Apply Duration",
18461846
"type": "bargauge"
18471847
},
18481848
{
@@ -2268,7 +2268,7 @@
22682268
"orientation": "auto",
22692269
"reduceOptions": {
22702270
"calcs": [
2271-
"mean"
2271+
"lastNotNull"
22722272
],
22732273
"fields": "",
22742274
"values": false
@@ -2286,7 +2286,7 @@
22862286
},
22872287
"disableTextWrap": false,
22882288
"editorMode": "code",
2289-
"expr": "sum by(kind) (resource_delete_duration_seconds_sum{namespace=\"$Namespace\"})",
2289+
"expr": "sum by(kind) (rate(resource_delete_duration_seconds_sum{namespace=\"$Namespace\"}[5m])) / sum by(kind) (rate(resource_delete_duration_seconds_count{namespace=\"$Namespace\"}[5m]))",
22902290
"fullMetaSearch": false,
22912291
"includeNullMetadata": true,
22922292
"instant": false,
@@ -2347,7 +2347,7 @@
23472347
"orientation": "auto",
23482348
"reduceOptions": {
23492349
"calcs": [
2350-
"max"
2350+
"lastNotNull"
23512351
],
23522352
"fields": "",
23532353
"values": false
@@ -2365,7 +2365,7 @@
23652365
},
23662366
"disableTextWrap": false,
23672367
"editorMode": "code",
2368-
"expr": "sum by(kind) (resource_delete_duration_seconds_sum{namespace=\"$Namespace\"})",
2368+
"expr": "histogram_quantile(0.99, sum by(le, kind) (rate(resource_delete_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
23692369
"fullMetaSearch": false,
23702370
"includeNullMetadata": true,
23712371
"instant": false,
@@ -2375,7 +2375,7 @@
23752375
"useBackend": false
23762376
}
23772377
],
2378-
"title": "Max Delete Duration",
2378+
"title": "p99 Delete Duration",
23792379
"type": "bargauge"
23802380
},
23812381
{
@@ -2426,7 +2426,7 @@
24262426
"orientation": "auto",
24272427
"reduceOptions": {
24282428
"calcs": [
2429-
"logmin"
2429+
"lastNotNull"
24302430
],
24312431
"fields": "",
24322432
"values": false
@@ -2444,7 +2444,7 @@
24442444
},
24452445
"disableTextWrap": false,
24462446
"editorMode": "code",
2447-
"expr": "sum by(kind) (resource_delete_duration_seconds_sum{namespace=\"$Namespace\"})",
2447+
"expr": "histogram_quantile(0.50, sum by(le, kind) (rate(resource_delete_duration_seconds_bucket{namespace=\"$Namespace\"}[5m])))",
24482448
"fullMetaSearch": false,
24492449
"includeNullMetadata": true,
24502450
"instant": false,
@@ -2454,7 +2454,7 @@
24542454
"useBackend": false
24552455
}
24562456
],
2457-
"title": "Min Delete Duration",
2457+
"title": "p50 Delete Duration",
24582458
"type": "bargauge"
24592459
},
24602460
{

0 commit comments

Comments
 (0)