refactor listener.IsReady()

Signed-off-by: zirain <zirain2009@gmail.com>

Author: zirain

internal/gatewayapi/contexts.go

@@ -274,13 +274,22 @@ func (l *ListenerContext) IsReady() bool {
 		conditions = l.gateway.Status.Listeners[l.listenerStatusIdx].Conditions
 	}
 
+	// No conditions yet means it will be set to ready during validation.
+	if len(conditions) == 0 {
+		return true
+	}
+
+	// Check if Accepted=False or Programmed=False exists.
 	for _, cond := range conditions {
-		if cond.Type == string(gwapiv1.ListenerConditionProgrammed) && cond.Status == metav1.ConditionTrue {
-			return true
+		if cond.Type == string(gwapiv1.ListenerConditionAccepted) && cond.Status == metav1.ConditionFalse {
+			return false
+		}
+		if cond.Type == string(gwapiv1.ListenerConditionProgrammed) && cond.Status == metav1.ConditionFalse {
+			return false
 		}
 	}
 
-	return false
+	return true
 }
 
 func (l *ListenerContext) GetNamespace() string {

internal/gatewayapi/listener.go

@@ -411,29 +411,6 @@ func (t *Translator) ProcessListeners(gateways []*GatewayContext, xdsIR resource
 	t.checkOverlappingTLSConfig(gateways)
 }
 
-// isListenerReady returns true if the listener is ready (Accepted=True and Programmed=True or no conditions yet).
-// A listener is not ready if it has Accepted=False or Programmed=False.
-func isListenerReady(listener *ListenerContext) bool {
-	conditions := listener.GetConditions()
-
-	// No conditions yet means it will be set to ready during validation.
-	if len(conditions) == 0 {
-		return true
-	}
-
-	// Check if Accepted=False or Programmed=False exists.
-	for _, cond := range conditions {
-		if cond.Type == string(gwapiv1.ListenerConditionAccepted) && cond.Status == metav1.ConditionFalse {
-			return false
-		}
-		if cond.Type == string(gwapiv1.ListenerConditionProgrammed) && cond.Status == metav1.ConditionFalse {
-			return false
-		}
-	}
-
-	return true
-}
-
 // checkOverlappingTLSConfig checks for overlapping hostnames and certificates between listeners and sets
 // the `OverlappingTLSConfig` condition if there are overlapping hostnames or certificates.
 func (t *Translator) checkOverlappingTLSConfig(gateways []*GatewayContext) {
@@ -442,7 +419,7 @@ func (t *Translator) checkOverlappingTLSConfig(gateways []*GatewayContext) {
 		httpsListeners := []*ListenerContext{}
 		for _, gateway := range gateways {
 			for _, listener := range gateway.listeners {
-				if listener.Protocol == gwapiv1.HTTPSProtocolType && isListenerReady(listener) {
+				if listener.Protocol == gwapiv1.HTTPSProtocolType && listener.IsReady() {
 					httpsListeners = append(httpsListeners, listener)
 				}
 			}
@@ -457,7 +434,7 @@ func (t *Translator) checkOverlappingTLSConfig(gateways []*GatewayContext) {
 		for _, gateway := range gateways {
 			httpsListeners := []*ListenerContext{}
 			for _, listener := range gateway.listeners {
-				if listener.Protocol == gwapiv1.HTTPSProtocolType && isListenerReady(listener) {
+				if listener.Protocol == gwapiv1.HTTPSProtocolType && listener.IsReady() {
 					httpsListeners = append(httpsListeners, listener)
 				}
 			}