Skip to content

Commit c229bba

Browse files
fix(helm): preserve envoyProxy provider configuration
Signed-off-by: Aditya7880900936 <adityasanskarsrivastav788@gmail.com>
1 parent dc63098 commit c229bba

10 files changed

Lines changed: 1704 additions & 6 deletions

File tree

charts/gateway-helm/templates/_helpers.tpl

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,17 +199,27 @@ The default Envoy Gateway configuration.
199199
{{- if .Values.global.images.envoyProxy.pullPolicy }}
200200
{{- $_ := set $container "imagePullPolicy" .Values.global.images.envoyProxy.pullPolicy }}
201201
{{- end }}
202-
{{- $deployment := dict "container" $container }}
202+
203+
{{- $workload := dict "container" $container }}
204+
203205
{{- if or .Values.global.imagePullSecrets .Values.global.images.envoyProxy.pullSecrets }}
204206
{{- $pullSecretsYaml := include "eg.envoyProxy.image.pullSecrets" . }}
205207
{{- $pullSecrets := dict "imagePullSecrets" ($pullSecretsYaml | fromYaml).imagePullSecrets }}
206-
{{- $_ := set $deployment "pod" $pullSecrets }}
208+
{{- $_ := set $workload "pod" $pullSecrets }}
209+
{{- end }}
210+
211+
{{- $envoyProvider := dig "provider" "kubernetes" dict $envoyProxyBase }}
212+
{{- $workloadKey := "envoyDeployment" }}
213+
214+
{{- if hasKey $envoyProvider "envoyDaemonSet" }}
215+
{{- $workloadKey = "envoyDaemonSet" }}
207216
{{- end }}
208-
{{- $kubernetes := dict "envoyDeployment" $deployment }}
217+
218+
{{- $kubernetes := dict $workloadKey $workload }}
209219
{{- $provider := dict "type" "Kubernetes" "kubernetes" $kubernetes }}
210220
{{- $imageOverride = dict "provider" $provider }}
211221
{{- end }}
212-
{{- $merged := mustMergeOverwrite (dict) $envoyProxyBase $imageOverride }}
222+
{{- $merged := mustMergeOverwrite (dict) (deepCopy $envoyProxyBase) $imageOverride }}
213223
envoyProxy:
214224
{{ toYaml $merged | indent 2 }}
215225
{{- end }}

release-notes/v1.8.1.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ bug fixes: |
3030
Fixed Gateway getting stuck at `Programmed=False` after its LoadBalancer Service IP was restored, by ignoring `LastTransitionTime` when comparing status conditions.
3131
Fixed HPA maxReplicas required message typo in gateway-helm chart.
3232
Fixed invalid listeners blocking valid ones during conflict detection by validating each listener's spec independently before running conflict resolution.
33-
33+
Fixed the gateway-helm chart to render the default EnvoyProxy image in the generated EnvoyGateway configuration while preserving existing `envoyDeployment` and `envoyDaemonSet` provider configurations.
3434
# Enhancements that improve performance.
3535
performance improvements: |
3636

site/content/en/community/RELEASING.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export GITHUB_REMOTE=origin
5555
```shell
5656
git checkout -b release/v${MAJOR_VERSION}.${MINOR_VERSION}
5757
```
58-
f
5958
8. Push the branch to the Envoy Gateway repo.
6059

6160
```shell

test/helm/gateway-helm/certgen-pod-securitycontext.out.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ data:
3232
envoy-gateway.yaml: |
3333
apiVersion: gateway.envoyproxy.io/v1alpha1
3434
kind: EnvoyGateway
35+
envoyProxy:
36+
provider:
37+
kubernetes:
38+
envoyDeployment:
39+
container:
40+
image: docker.io/envoyproxy/envoy:distroless-dev
41+
type: Kubernetes
3542
extensionApis: {}
3643
gateway:
3744
controllerName: gateway.envoyproxy.io/gatewayclass-controller

test/helm/gateway-helm/deployment-strategy.out.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ data:
3232
envoy-gateway.yaml: |
3333
apiVersion: gateway.envoyproxy.io/v1alpha1
3434
kind: EnvoyGateway
35+
envoyProxy:
36+
provider:
37+
kubernetes:
38+
envoyDeployment:
39+
container:
40+
image: docker.io/envoyproxy/envoy:distroless-dev
41+
type: Kubernetes
3542
extensionApis: {}
3643
gateway:
3744
controllerName: gateway.envoyproxy.io/gatewayclass-controller

test/helm/gateway-helm/deployment-wasm-cache-volume.out.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ data:
3232
envoy-gateway.yaml: |
3333
apiVersion: gateway.envoyproxy.io/v1alpha1
3434
kind: EnvoyGateway
35+
envoyProxy:
36+
provider:
37+
kubernetes:
38+
envoyDeployment:
39+
container:
40+
image: docker.io/envoyproxy/envoy:distroless-dev
41+
type: Kubernetes
3542
extensionApis: {}
3643
gateway:
3744
controllerName: gateway.envoyproxy.io/gatewayclass-controller
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
global:
2+
images:
3+
envoyProxy:
4+
image: "private-hub/envoyproxy/envoy:dev"
5+
6+
config:
7+
envoyGateway:
8+
envoyProxy:
9+
provider:
10+
type: Kubernetes
11+
kubernetes:
12+
envoyDaemonSet:
13+
name: test-daemonset

0 commit comments

Comments
 (0)