Skip to content

Helm chart nameOverride of Deployment/Service/ConfigMap/ServiceAccount, etc. #8156

@illrill

Description

@illrill

The chart already implements the standard nameOverride and fullnameOverride helpers and also uses {{ include "eg.fullname" . }} to name some resources (for example all RBAC, the certgen and the topology injector components). However the "primary" resources like the Deployment, Service, ConfigMap, ServiceAccount, etc. are hardcoded to be named envoy-gateway. So it's a bit inconsistent and I'd like the ability to override the names of these resources too.

If we are to align with how most other charts do it, we would basically:

 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: envoy-gateway
+  name: {{ include "eg.fullname" . }}
   namespace: '{{ .Release.Namespace }}'
 apiVersion: v1
 kind: ConfigMap
 metadata:
-  name: envoy-gateway-config
+  name: {{ include "eg.fullname" . }}-config
   namespace: '{{ .Release.Namespace }}'

I can submit a PR for this, if you're open to the idea!

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions