feat: add envoyproxy status by zirain · Pull Request #8475 · envoyproxy/gateway

zirain · 2026-03-10T10:36:30Z

This's the first part of implement envoyproxy status, set EnvoyProxy status when it's invalid.
We may want to remove the one on Gateway/GatewayClass in the next step.

netlify · 2026-03-10T10:36:37Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`4bf4549`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a031dd1396fb9000813d8be
😎 Deploy Preview	https://deploy-preview-8475--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-03-10T11:50:22Z

Codecov Report

❌ Patch coverage is 54.88722% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.69%. Comparing base (9430ab9) to head (4bf4549).

Files with missing lines	Patch %	Lines
internal/gatewayapi/runner/runner.go	26.82%	26 Missing and 4 partials ⚠️
internal/provider/kubernetes/status.go	15.62%	26 Missing and 1 partial ⚠️
internal/provider/kubernetes/controller.go	57.14%	3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (54.88%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8475      +/-   ##
==========================================
- Coverage   74.75%   74.69%   -0.07%     
==========================================
  Files         251      252       +1     
  Lines       40397    40522     +125     
==========================================
+ Hits        30198    30267      +69     
- Misses       8132     8185      +53     
- Partials     2067     2070       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-04-12T08:15:12Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

zhaohuabing · 2026-04-14T14:25:06Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ddd7d2f5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

zhaohuabing

Since there are no conformance tests for EnvoyProxy status, can we add an e2e test to ensure the runtime behavior is correct?

zirain · 2026-04-15T23:25:44Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a17a9b6e49

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

zhaohuabing · 2026-04-29T01:09:14Z

-
+	if gc != nil {
+		// this won't happen in real world, just a safety check to make sure the testdata won't be a mess.
+		translateResult.EnvoyProxyForGatewayClass = envoyProxyForGC


Non-blocking nit: should this be fixed in the test fixtures instead?

zhaohuabing · 2026-04-29T01:17:08Z

We may want to remove the one on Gateway/GatewayClass in the next step.

We probably should keep the status in the Gateway/GatwayClass as well - it's easier to figure out the parameter is invalid in the Gateway/GatewayClass status.

zhaohuabing

LGTM thanks!

jukie · 2026-04-29T22:44:46Z

Can you re-gen?

zirain · 2026-04-29T23:38:27Z

Can you re-gen?

done

zhaohuabing · 2026-04-30T01:32:57Z

/retest

zirain · 2026-04-30T12:51:46Z

/retest

Signed-off-by: zirain <zirain2009@gmail.com>

* nit Signed-off-by: zirain <zirain2009@gmail.com> * add envoyproxy status Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * perf Signed-off-by: zirain <zirain2009@gmail.com> * fix Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> * comment and nit Signed-off-by: zirain <zirain2009@gmail.com> * fix status and more e2e Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: nguyenptk <nguyenptk@gmail.com>

* nit Signed-off-by: zirain <zirain2009@gmail.com> * add envoyproxy status Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * perf Signed-off-by: zirain <zirain2009@gmail.com> * fix Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> * comment and nit Signed-off-by: zirain <zirain2009@gmail.com> * fix status and more e2e Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com>

zirain marked this pull request as ready for review March 12, 2026 01:52

zirain requested a review from a team as a code owner March 12, 2026 01:52

zirain force-pushed the impl-envoyproxy-status branch from b810b41 to 81f65cc Compare March 12, 2026 01:52

zirain changed the title ~~feat: impl envoyproxy status~~ feat: add envoyproxy status Mar 12, 2026

stekole reviewed Mar 12, 2026

View reviewed changes

Comment thread internal/gatewayapi/status/envoyproxy.go Outdated

zirain force-pushed the impl-envoyproxy-status branch 2 times, most recently from 5e08ea1 to 8ddd7d2 Compare March 13, 2026 06:22

zirain added this to the v1.8.0-rc.1 Release milestone Mar 13, 2026

github-actions Bot added stale and removed stale labels Apr 12, 2026

zhaohuabing reviewed Apr 14, 2026

View reviewed changes

Comment thread internal/cmd/egctl/testdata/translate/out/valid-envoyproxy.all.yaml Outdated

chatgpt-codex-connector Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread internal/gatewayapi/status/envoyproxy.go Outdated

zhaohuabing requested changes Apr 14, 2026

View reviewed changes

zirain force-pushed the impl-envoyproxy-status branch 2 times, most recently from 5c363c6 to b4fd2d6 Compare April 15, 2026 06:19

zirain requested a review from zhaohuabing April 15, 2026 10:11

chatgpt-codex-connector Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread internal/gatewayapi/runner/runner.go Outdated

Comment thread internal/provider/kubernetes/status.go

zirain mentioned this pull request Apr 19, 2026

fix(translator): set status for invalid EnvoyPatchPolicy target kind #8788

Closed

zhaohuabing reviewed Apr 29, 2026

View reviewed changes

zhaohuabing previously approved these changes Apr 29, 2026

View reviewed changes

zirain dismissed zhaohuabing’s stale review via 9c9f984 April 29, 2026 23:27

zirain requested a review from zhaohuabing April 29, 2026 23:38

zhaohuabing approved these changes Apr 30, 2026

View reviewed changes

jukie approved these changes Apr 30, 2026

View reviewed changes

arkodg modified the milestones: v1.8.0-rc.1 Release, v1.9.0-rc.1 Release Apr 30, 2026

zirain added 10 commits May 12, 2026 20:32

nit

83c2a6f

Signed-off-by: zirain <zirain2009@gmail.com>

add envoyproxy status

ee92c35

Signed-off-by: zirain <zirain2009@gmail.com>

fix gen

140ed65

Signed-off-by: zirain <zirain2009@gmail.com>

lint

f442605

Signed-off-by: zirain <zirain2009@gmail.com>

perf

8c2cc69

Signed-off-by: zirain <zirain2009@gmail.com>

fix

57f1a02

Signed-off-by: zirain <zirain2009@gmail.com>

fix gen

c428656

Signed-off-by: zirain <zirain2009@gmail.com>

comment and nit

9ebb393

Signed-off-by: zirain <zirain2009@gmail.com>

fix status and more e2e

88d321c

Signed-off-by: zirain <zirain2009@gmail.com>

fix gen

4bf4549

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the impl-envoyproxy-status branch from 04cee50 to 4bf4549 Compare May 12, 2026 12:32

zirain merged commit 52f9e50 into envoyproxy:main May 14, 2026
62 of 65 checks passed

zirain deleted the impl-envoyproxy-status branch May 14, 2026 05:58

Uh oh!

Conversation

zirain commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

codecov Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions Bot commented Apr 12, 2026

Uh oh!

Uh oh!

zhaohuabing commented Apr 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

zhaohuabing left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zirain commented Apr 15, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

zhaohuabing Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhaohuabing commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhaohuabing left a comment

Choose a reason for hiding this comment

Uh oh!

jukie commented Apr 29, 2026

Uh oh!

zirain commented Apr 29, 2026

Uh oh!

zhaohuabing commented Apr 30, 2026

Uh oh!

zirain commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zirain commented Mar 10, 2026 •

edited

Loading

netlify Bot commented Mar 10, 2026 •

edited

Loading

codecov Bot commented Mar 10, 2026 •

edited

Loading

zhaohuabing left a comment •

edited

Loading

zhaohuabing Apr 29, 2026 •

edited

Loading

zhaohuabing commented Apr 29, 2026 •

edited

Loading