feat: allow to patch multiple resources with EPP#8518
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ed6c528 to
ded9e1e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8518 +/- ##
==========================================
- Coverage 75.59% 75.48% -0.11%
==========================================
Files 252 252
Lines 41713 41811 +98
==========================================
+ Hits 31531 31563 +32
- Misses 8057 8108 +51
- Partials 2125 2140 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ded9e1e to
ec71f58
Compare
71f5191 to
2b6f0f4
Compare
| // If there are multiple dests and some of them fail, | ||
| // consider it as successful and ignore the failures to patch other dests. | ||
| if !anyPatched && patchErrors != nil { | ||
| tErrs = errors.Join(tErrs, patchErrors) |
There was a problem hiding this comment.
Is there a better way to handle partial failures rather than marking as programmed and success? How does a user monitor and/or become aware of failures?
There was a problem hiding this comment.
it's hard, you may want to add a http filter to all listener, but it will failed on tcp listeners which is valid.
a30674c to
5a0b04d
Compare
|
can we update the title to |
zirain
changed the title
d2f646a to
2d1bd50
Compare
f638718 to
3a7991f
Compare
830fbd4 to
84692af
Compare
zirain
changed the title
eb4b4b5 to
73a6372
Compare
73a6372 to
8022ef1
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8022ef1558
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d71e5f92ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d71e5f9 to
3b2041a
Compare
| status.SetAcceptedForPolicyAncestor(&policy.Status, &ancestorRef, t.GatewayControllerName, policy.Generation) | ||
| } else { | ||
| // Clear any partial patches that were added before validation failed | ||
| policyIR.JSONPatches = nil |
There was a problem hiding this comment.
this is changing the existing logic, curious why we are doing it in this PR
e721c79 to
b2ec896
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2ec8965a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if !ok { | ||
| continue | ||
| } | ||
| if stringMatched(name, listener.Name) { |
There was a problem hiding this comment.
When a policy uses a broad listener selector such as the new e2e RegularExpression: .*, this loop also selects the generated readiness listener (envoy-gateway-proxy-ready-*) from the same resource table, not just the listeners for the targeted Gateway. Patches that are valid for Gateway HTTP listeners, for example /default_filter_chain/... in test/e2e/testdata/envoy-patch-policy.yaml, then fail against the readiness listener and mark the policy Programmed=False, or can unintentionally mutate readiness configuration.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this could be avoided by using corrected regex expression, @envoyproxy/gateway-maintainers should we leave this to users?
15d2562 to
723f64b
Compare
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
723f64b to
da6cc12
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
da6cc12 to
025b3a3
Compare
3 participants
fixes: #8489