feat(ext_proc): add support for observability mode - #8536
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
e05c278 to
c25a980
Compare
| // +optional | ||
| ProcessingMode *ExtProcProcessingMode `json:"processingMode,omitempty"` | ||
|
|
||
| // ObservabilityMode sets if envoy gateway should treat this external processor as "send and go" |
There was a problem hiding this comment.
should this be called ShadowMode instead to keep naming unform ?
@envoyproxy/gateway-maintainers
There was a problem hiding this comment.
+1 on ShadowMode which keep same as Ratelimit.
| // ObservabilityMode sets if envoy gateway should treat this external processor as "send and go" | ||
| // | ||
| // +optional | ||
| // +kubebuilder:default=false |
There was a problem hiding this comment.
lets rm the kubebuilder annotation, and add a comment instead that it defaults to false
4cfd91c to
a2927a0
Compare
|
@arkodg anything we can do to progress this (I'll fix the DCO shortly) |
|
ptal @envoyproxy/gateway-maintainers |
|
overall lgtm, let's just align the naming. |
Signed-off-by: Jake Oliver <jake@truelayer.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
4b8204e to
1c24edb
Compare
|
Thanks folks for your review. I've fixed DCO and now updated all of the references to be |
d83041a to
7ed9ec2
Compare
Signed-off-by: Jake Oliver <jake@truelayer.com>
7ed9ec2 to
5d96dd4
Compare
|
@arkodg sorry for the poke. any chance of us getting this reviewed and merged before the next release 🥺 |
|
Hi @skos-ninja - looks like 1.8.0 RC was already cut, so we're now in an API freeze until the release. Apologies that it didn't make it in 1.8.*. |
|
hey @skos-ninja can you fix |
Signed-off-by: Jake Oliver <jake@truelayer.com>
Signed-off-by: Jake Oliver <jake@truelayer.com>
|
Hey @arkodg I've changed the errors I can see but for some reason when I run Is it possible to run the actions again so I can see the output here? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
Nooo! @arkodg @guydc can we please release this? This will unblock some of the initiatives at our org. cc: @skos-ninja 🙏 |
|
@skos-ninja can you make the CI happy? |
Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
…t/ext_proc/obsv_mode Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
… test Signed-off-by: Lee Boynton <lee.boynton@truelayer.com>
Hopefully it should pass now 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8536 +/- ##
=======================================
Coverage 75.28% 75.28%
=======================================
Files 252 252
Lines 41536 41540 +4
=======================================
+ Hits 31271 31275 +4
- Misses 8141 8142 +1
+ Partials 2124 2123 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
1 similar comment
|
/retest |
6 participants
What this PR does / why we need it:
Adds support for setting
observability_modewithin theext_procso that non blocking processors are able to be setup using CRDs.We need this in order to enable admission hooks within our infrastructure that allows us to enforce that certain
ext_proc's that are setup in the correct wayWhich issue(s) this PR fixes:
Fixes #8289
Release Notes: Yes (but currently not added)