-
Notifications
You must be signed in to change notification settings - Fork 820
feat: introduce EndpointHostname in BTP to set hostname field in Endpoint #8606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhuoyang
wants to merge
19
commits into
envoyproxy:main
Choose a base branch
from
zhuoyang:implement-backend-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ecb2a85
feat: support HTTPURLRewriteFilter hostname.type: Backend for k8s ser…
zhuoyang 806e05f
add release notes
zhuoyang 078305e
Merge branch 'main' into implement-backend-service
zhuoyang 6cb6abc
fix empty resource metadata for service
zhuoyang bafdd3c
fix yaml lint
zhuoyang caf4e78
fix test coverage
zhuoyang 6247196
fix golint again
zhuoyang aa83d55
Merge branch 'main' into implement-backend-service
zhuoyang 7e43337
Merge branch 'main' into implement-backend-service
zhuoyang d85af66
Merge branch 'main' into implement-backend-service
zhuoyang d04c2c6
introduce new BTP knob to control hostname
zhuoyang cab5a84
Merge remote-tracking branch 'origin/main' into implement-backend-ser…
zhuoyang 30aa2eb
fix
zhuoyang 2d5b57f
Merge remote-tracking branch 'origin/main' into implement-backend-ser…
zhuoyang 648c036
add static type, fix test
zhuoyang a20f01e
revert: drop unrelated Service kind defaulting in buildResourceMetadata
zhuoyang d1f621b
fix lint and remove ptr
zhuoyang b4c1425
Merge remote-tracking branch 'origin/main' into implement-backend-ser…
zhuoyang 5593590
Merge branch 'main' into implement-backend-service
zhuoyang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesnt the HTTPRouteFilter or Backend resource solve this use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it needs to be explicit, there is no option for it to follow kuberentes service fqdn