docs(cors): show allowCredentials in the CORS task - #8611
Merged
jukie merged 2 commits intoApr 23, 2026
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
force-pushed
the
docs/cors-allowcredentials
branch
from
March 29, 2026 12:58
cfe8bf0 to
1c74ec2
Compare
zirain
approved these changes
Mar 29, 2026
jukie
approved these changes
Apr 23, 2026
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
docs: show allowCredentials in the CORS task
What this PR does / why we need it:
Updates the CORS task guide so the example manifests explicitly show
allowCredentials: trueand the sample response includesaccess-control-allow-credentials: true. This makes it clearer that the task docs cover credentialed CORS requests supported by the API.Which issue(s) this PR fixes:
Fixes #8366
Release Notes: No