feat(helm): add eg.fullname support for resources names (#8156)#8628
Open
Miracle05 wants to merge 1 commit intoenvoyproxy:mainfrom
Open
feat(helm): add eg.fullname support for resources names (#8156)#8628Miracle05 wants to merge 1 commit intoenvoyproxy:mainfrom
Miracle05 wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
❌ Deploy Preview for cerulean-figolla-1f9435 failed.
|
Miracle05
force-pushed
the
issue-8156
branch
2 times, most recently
from
8e78c4a to
233e321
Compare
Miracle05
changed the title
Signed-off-by: Dmitrii Golubtsov <evarome10@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: add eg.fullname support for resources names (#8156)
What this PR does / why we need it:
Fixed hardcoded resources names in Helm chart (#8156)
Which issue(s) this PR fixes:
Fixes #8156
Release Notes:
BREAKING CHANGES:
It will change resources labels:
app.kubernetes.io/name: gateway-helm -> envoy-gateway
And names for some resources:
ClusterRole, ClusterRoleBinding, Role, RoleBinding, ServiceAccount