Skip to content

api: add bandwidth limit#8630

Merged
jukie merged 13 commits intoenvoyproxy:mainfrom
kkk777-7:feat-bandwidth-api
Apr 25, 2026
Merged

api: add bandwidth limit#8630
jukie merged 13 commits intoenvoyproxy:mainfrom
kkk777-7:feat-bandwidth-api

Conversation

@kkk777-7
Copy link
Copy Markdown
Member

@kkk777-7 kkk777-7 commented Mar 31, 2026

What this PR does / why we need it:
Add bandwidth limit api in BackendTrafficPolicy. #4328

envoy related document: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/bandwidth_limit/v3/bandwidth_limit.proto#envoy-v3-api-msg-extensions-filters-http-bandwidth-limit-v3-bandwidthlimit

Which issue(s) this PR fixes:

Fixes #4328 (needs follow-up implement pr)

Release Notes: No

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7 kkk777-7 requested a review from a team as a code owner March 31, 2026 17:00
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 9a271b7
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e9c08d81a39900088a3c4b

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.63%. Comparing base (028ce99) to head (9a271b7).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8630      +/-   ##
==========================================
- Coverage   73.63%   73.63%   -0.01%     
==========================================
  Files         245      246       +1     
  Lines       48864    49076     +212     
==========================================
+ Hits        35981    36137     +156     
- Misses      10878    10917      +39     
- Partials     2005     2022      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Comment thread api/v1alpha1/bandwidthlimit_types.go
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
Copy link
Copy Markdown
Member Author

kkk777-7 commented Apr 1, 2026

/retest

Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
kkk777-7 added 3 commits April 6, 2026 23:29
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
Copy link
Copy Markdown
Member Author

kkk777-7 commented Apr 9, 2026

/retest

Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Apr 12, 2026
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
Copy link
Copy Markdown
Member Author

thanks @arkodg! I've addressed.

Comment thread api/v1alpha1/bandwidthlimit_types.go
Comment thread api/v1alpha1/bandwidthlimit_types.go
Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
Copy link
Copy Markdown
Member Author

thanks @zhaohuabing , I've addressed.
when you have a moment, please take a second look.

Comment thread api/v1alpha1/bandwidthlimit_types.go Outdated
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kkk777-7
Copy link
Copy Markdown
Member Author

/retest

@jukie jukie merged commit e098718 into envoyproxy:main Apr 25, 2026
61 of 64 checks passed
@kkk777-7 kkk777-7 mentioned this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support BandwidthLimiting

5 participants