Skip to content

feat: Add BackendUtilization + WeightedZones support (WrrLocality Lb policy)#8634

Merged
jukie merged 28 commits intoenvoyproxy:mainfrom
jukie:wrr-locality-support
Apr 23, 2026
Merged

feat: Add BackendUtilization + WeightedZones support (WrrLocality Lb policy)#8634
jukie merged 28 commits intoenvoyproxy:mainfrom
jukie:wrr-locality-support

Conversation

@jukie
Copy link
Copy Markdown
Contributor

@jukie jukie commented Apr 1, 2026

What this PR does / why we need it:
Adds the ability to use wrr_locality which is a wrapped Lb Policy of client_side_weighted_round_robin while respecting locality weights.

Which issue(s) this PR fixes:

Fixes #8635

Release Notes: No - Existing release note for BackendUtilization is sufficient. I'll follow-up after this with a docs example too.

Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit cd3c9f8
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e9a71423c7870008568252
😎 Deploy Preview https://deploy-preview-8634--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jukie jukie changed the title Add BackendUtilization + WeightedZones support (WrrLocality Lb policy) feat: Add BackendUtilization + WeightedZones support (WrrLocality Lb policy) Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 86.15385% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.64%. Comparing base (7b14b5b) to head (cd3c9f8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 86.15% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8634      +/-   ##
==========================================
+ Coverage   73.62%   73.64%   +0.02%     
==========================================
  Files         246      246              
  Lines       49076    49109      +33     
==========================================
+ Hits        36131    36167      +36     
+ Misses      10923    10919       -4     
- Partials     2022     2023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jukie jukie marked this pull request as ready for review April 1, 2026 03:24
@jukie jukie requested a review from a team as a code owner April 1, 2026 03:24
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 3, 2026

/retest

Comment thread api/v1alpha1/loadbalancer_types.go
arkodg
arkodg previously approved these changes Apr 12, 2026
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg arkodg added this to the v1.8.0-rc.1 Release milestone Apr 12, 2026
jukie and others added 2 commits April 12, 2026 10:40
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 12, 2026

CEL was broken, fixed

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 12, 2026

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 13, 2026

/retest

@jukie jukie requested a review from zhaohuabing April 13, 2026 23:25
@jukie jukie requested a review from a team April 13, 2026 23:25
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 14, 2026

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3710147722

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/content/en/latest/tasks/traffic/zone-aware-routing.md Outdated
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 14, 2026

/retest

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 14, 2026

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d1822a81d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/e2e/tests/load_balancing.go Outdated
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie jukie force-pushed the wrr-locality-support branch from 3cd839f to 4a3795c Compare April 15, 2026 01:09
@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 16, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jukie jukie requested review from a team April 19, 2026 01:40
@jukie jukie merged commit 78380e4 into envoyproxy:main Apr 23, 2026
52 of 54 checks passed
@jukie jukie deleted the wrr-locality-support branch April 23, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for wrr_locality load balancing policy

4 participants