feat: add extraEnv support to envoy-gateway controller deployment - #8733
Merged
Conversation
Add deployment.envoyGateway.extraEnv to the gateway-helm chart values, allowing operators to inject additional environment variables into the controller container. The controller deployment template currently hardcodes two env vars (ENVOY_GATEWAY_NAMESPACE and KUBERNETES_CLUSTER_DOMAIN) with no way to add more. This makes it impossible to configure behavior controlled by standard environment variables (e.g. OTEL_METRICS_EXEMPLAR_FILTER, GOGC, GOMEMLIMIT) without patching the deployment out-of-band. Fixes envoyproxy#8732 Signed-off-by: Giri Kuncoro <girikuncoro@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
girikuncoro
force-pushed
the
extraenv-support
branch
4 times, most recently
from
April 13, 2026 11:02
b587f3b to
e32e58e
Compare
girikuncoro
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8733 +/- ##
==========================================
- Coverage 74.41% 73.68% -0.74%
==========================================
Files 245 245
Lines 38977 48803 +9826
==========================================
+ Hits 29006 35959 +6953
- Misses 7967 10845 +2878
+ Partials 2004 1999 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
girikuncoro
force-pushed
the
extraenv-support
branch
2 times, most recently
from
April 14, 2026 08:30
38acc96 to
af3239d
Compare
Contributor
Author
|
The coverage test fails, might not be relevant to my change / flaky |
Contributor
|
thanks, can you also add a test in https://github.com/envoyproxy/gateway/tree/main/test/helm |
girikuncoro
force-pushed
the
extraenv-support
branch
from
April 21, 2026 12:36
af3239d to
c23b844
Compare
Signed-off-by: Giri Kuncoro <girikuncoro@gmail.com>
girikuncoro
force-pushed
the
extraenv-support
branch
from
April 21, 2026 12:56
c23b844 to
b7ff35a
Compare
Contributor
Author
|
@arkodg thank you for the feedback! I've added the tests, hopefully this would be sufficient |
zirain
approved these changes
Apr 22, 2026
skos-ninja
pushed a commit
to skos-ninja/envoy-gateway
that referenced
this pull request
May 1, 2026
…voyproxy#8733) * feat: add extraEnv support to envoy-gateway controller deployment Add deployment.envoyGateway.extraEnv to the gateway-helm chart values, allowing operators to inject additional environment variables into the controller container. The controller deployment template currently hardcodes two env vars (ENVOY_GATEWAY_NAMESPACE and KUBERNETES_CLUSTER_DOMAIN) with no way to add more. This makes it impossible to configure behavior controlled by standard environment variables (e.g. OTEL_METRICS_EXEMPLAR_FILTER, GOGC, GOMEMLIMIT) without patching the deployment out-of-band. Fixes envoyproxy#8732 Signed-off-by: Giri Kuncoro <girikuncoro@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
deployment.envoyGateway.extraEnvto thegateway-helmchart, allowing operators to inject additional environment variables into the controller container.Usage Example
Why
The controller deployment template hardcodes two env vars (
ENVOY_GATEWAY_NAMESPACEandKUBERNETES_CLUSTER_DOMAIN) with no mechanism to add more. This makes it impossible to configure behavior controlled by standard environment variables (e.g.OTEL_METRICS_EXEMPLAR_FILTER,GOGC,GOMEMLIMIT) without patching the deployment out-of-band.Fixes #8732