api: add cel validation of GrpcStatus - #8803
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| // +optional | ||
| GrpcStatus *int32 `json:"grpcStatus,omitempty"` | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +kubebuilder:validation:Maximum=16 |
There was a problem hiding this comment.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f661cda5a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8803 +/- ##
==========================================
- Coverage 73.62% 73.62% -0.01%
==========================================
Files 246 246
Lines 49076 49076
==========================================
- Hits 36131 36130 -1
- Misses 10923 10925 +2
+ Partials 2022 2021 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
f661cda to
3b79171
Compare
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
kkk777-7
changed the title
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
| // | ||
| // +optional | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +kubebuilder:validation:Maximum=16 |
There was a problem hiding this comment.
yes, I've add cel test.
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
|
/retest |
|
/retest |
* add cel validation of grpcStatus Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * fix: gen-check Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: cel test Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Co-authored-by: Isaac Wilson <isaac.wilson514@gmail.com> Signed-off-by: Jake Oliver <jake@truelayer.com>
4 participants
What this PR does / why we need it:
Improve: add validation of valid values.
Related: #8800
Which issue(s) this PR fixes:
Fixes #
Release Notes: No