Skip to content

feat(helm): add startupProbe to envoy-gateway deployment#8820

Merged
zirain merged 8 commits into
envoyproxy:mainfrom
cleman95:feat/startup-probe-gtw
Jul 22, 2026
Merged

feat(helm): add startupProbe to envoy-gateway deployment#8820
zirain merged 8 commits into
envoyproxy:mainfrom
cleman95:feat/startup-probe-gtw

Conversation

@cleman95

@cleman95 cleman95 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Add startupProbe with 1s period and 30s max wait
  • Remove initialDelaySeconds from liveness/readiness
  • Move probe configs to values.tmpl.yaml for customization

Which issue(s) this PR fixes:

Fixes #8719

Release Notes: Yes

@cleman95
cleman95 requested a review from a team as a code owner April 22, 2026 11:36
@netlify

netlify Bot commented Apr 22, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 9bbb9e4
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a5f73bac37d6200085a96cc
😎 Deploy Preview https://deploy-preview-8820--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch from 7c33ada to dedbdf7 Compare April 22, 2026 11:48
@zirain

zirain commented Apr 27, 2026

Copy link
Copy Markdown
Member

please rune make gen-check and commit the changes to make the CI happy.

@codecov

codecov Bot commented Apr 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.55%. Comparing base (2874485) to head (9bbb9e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8820      +/-   ##
==========================================
- Coverage   75.59%   75.55%   -0.04%     
==========================================
  Files         252      252              
  Lines       41713    41713              
==========================================
- Hits        31531    31515      -16     
- Misses       8057     8069      +12     
- Partials     2125     2129       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch from aebbd81 to d5e6ea5 Compare April 27, 2026 09:45
Comment thread test/helm/gateway-helm/certgen-annotations.out.yaml
jukie
jukie previously approved these changes Apr 29, 2026

@jukie jukie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jukie
jukie requested a review from a team April 29, 2026 19:49
zirain
zirain previously approved these changes Apr 30, 2026
@jukie

jukie commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

/retest

Comment thread charts/gateway-helm/values.tmpl.yaml Outdated
Comment thread charts/gateway-helm/values.tmpl.yaml
@arkodg arkodg added this to the v1.9.0-rc.1 Release milestone May 11, 2026
@cleman95
cleman95 dismissed stale reviews from zirain and jukie via 6ef4a6e May 11, 2026 09:55
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jun 10, 2026
@zirain
zirain force-pushed the feat/startup-probe-gtw branch from 6ef4a6e to ab43efa Compare June 11, 2026 01:14
@zirain

zirain commented Jun 11, 2026

Copy link
Copy Markdown
Member

@cleman95 are you still working on this, if so, can you add a release notes?

@github-actions github-actions Bot removed the stale label Jun 11, 2026
@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch from f34e64c to bf0b6c8 Compare June 12, 2026 08:28
@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch from bf0b6c8 to 1d0f28f Compare June 23, 2026 21:47
@cleman95

Copy link
Copy Markdown
Contributor Author

I've added the release note sorry for the delay

@jukie

jukie commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Can you run "make gen-check" and commit the result?

@zirain

zirain commented Jun 25, 2026

Copy link
Copy Markdown
Member

can you rework the release notes based on #9312?

@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch 3 times, most recently from 5da6a61 to 08764e2 Compare June 25, 2026 11:54
zirain
zirain previously approved these changes Jun 25, 2026
zirain
zirain previously approved these changes Jul 1, 2026
@zirain
zirain requested a review from a team July 1, 2026 23:50
@arkodg

arkodg commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

hey @cleman95 can you rebase and push, tia

arkodg
arkodg previously approved these changes Jul 20, 2026
@cleman95
cleman95 dismissed stale reviews from arkodg and zirain via 1925683 July 20, 2026 08:13
@cleman95
cleman95 force-pushed the feat/startup-probe-gtw branch from e6162cf to 1925683 Compare July 20, 2026 08:13
cleman95 added 6 commits July 21, 2026 09:31
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
@zirain
zirain force-pushed the feat/startup-probe-gtw branch from 1925683 to 7a245e4 Compare July 21, 2026 01:31
zirain
zirain previously approved these changes Jul 21, 2026
jukie
jukie previously approved these changes Jul 21, 2026
@zirain

zirain commented Jul 21, 2026

Copy link
Copy Markdown
Member

@cleman95 can you fix the lint?

Signed-off-by: Clement Phu <clement.phu@hotmail.fr>
@cleman95
cleman95 dismissed stale reviews from jukie and zirain via 9bbb9e4 July 21, 2026 13:27
@cleman95

Copy link
Copy Markdown
Contributor Author

Sure, sorry

@zirain

zirain commented Jul 21, 2026

Copy link
Copy Markdown
Member

/retest

@zirain
zirain merged commit 7a50638 into envoyproxy:main Jul 22, 2026
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StartupProbe missing from helm charts

4 participants