let runTrafficTest polling retry on mismatch - #8830
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
66dc61e to
3d26bcd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8830 +/- ##
==========================================
- Coverage 73.64% 73.61% -0.03%
==========================================
Files 246 246
Lines 49076 49109 +33
==========================================
+ Hits 36140 36154 +14
- Misses 10916 10930 +14
- Partials 2020 2025 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
What this PR does / why we need it:
runTrafficTest was calling t.FailNow() whenever compareFunc returned false, which aborted the subtest before wait.PollUntilContextTimeout could retry. The BackendUtilizationLoadBalancing warmup subtest expects retries while Envoy's EDS cluster converges to healthy endpoints, so a single empty trafficMap on the first iteration would fail the test outright. Return false instead and move the diagnostic cluster dump into each caller's poll-timeout branch so it runs once on real failure rather than on every retry.
Fixes #8826