Skip to content

let runTrafficTest polling retry on mismatch - #8830

Closed
jukie wants to merge 2 commits into
envoyproxy:mainfrom
jukie:fix/load-balancing-test-retry
Closed

let runTrafficTest polling retry on mismatch#8830
jukie wants to merge 2 commits into
envoyproxy:mainfrom
jukie:fix/load-balancing-test-retry

Conversation

@jukie

@jukie jukie commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

runTrafficTest was calling t.FailNow() whenever compareFunc returned false, which aborted the subtest before wait.PollUntilContextTimeout could retry. The BackendUtilizationLoadBalancing warmup subtest expects retries while Envoy's EDS cluster converges to healthy endpoints, so a single empty trafficMap on the first iteration would fail the test outright. Return false instead and move the diagnostic cluster dump into each caller's poll-timeout branch so it runs once on real failure rather than on every retry.

Fixes #8826

@netlify

netlify Bot commented Apr 23, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 78ffdc5
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69e9c41c123ba1000877309f
😎 Deploy Preview https://deploy-preview-8830--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: jukie <10012479+jukie@users.noreply.github.com>
@jukie
jukie force-pushed the fix/load-balancing-test-retry branch from 66dc61e to 3d26bcd Compare April 23, 2026 05:35
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.61%. Comparing base (f394346) to head (78ffdc5).
⚠️ Report is 171 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8830      +/-   ##
==========================================
- Coverage   73.64%   73.61%   -0.03%     
==========================================
  Files         246      246              
  Lines       49076    49109      +33     
==========================================
+ Hits        36140    36154      +14     
- Misses      10916    10930      +14     
- Partials     2020     2025       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added stale and removed stale labels May 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jun 22, 2026
@github-actions github-actions Bot closed this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FAIL: TestE2E/BackendUtilizationLoadBalancing

1 participant