Skip to content

chore: use os.Stdout instead of t.Output() - #8860

Merged
zirain merged 1 commit into
envoyproxy:mainfrom
zirain:fix-race
May 9, 2026
Merged

chore: use os.Stdout instead of t.Output()#8860
zirain merged 1 commit into
envoyproxy:mainfrom
zirain:fix-race

Conversation

@zirain

@zirain zirain commented Apr 25, 2026

Copy link
Copy Markdown
Member

xref: https://github.com/envoyproxy/gateway/actions/runs/24942232519/job/73037758485

Note: In production, certGen is called with cmd.OutOrStdout() which resolves to os.Stdout
in most cases, so using os.Stdout in tests mirrors real-world behavior.

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
zirain requested a review from a team as a code owner April 25, 2026 23:12
@netlify

netlify Bot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit f991936
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ed4a534a96c50008010799
😎 Deploy Preview https://deploy-preview-8860--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Apr 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.36%. Comparing base (7811d86) to head (f991936).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8860      +/-   ##
==========================================
- Coverage   74.37%   74.36%   -0.02%     
==========================================
  Files         246      246              
  Lines       39287    39287              
==========================================
- Hits        29218    29214       -4     
- Misses       8040     8044       +4     
  Partials     2029     2029              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain
zirain merged commit 3439cef into envoyproxy:main May 9, 2026
75 of 79 checks passed
@zirain
zirain deleted the fix-race branch May 9, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants