docs: fix ClientTrafficPolicy page for targeting all listeners - #8892
docs: fix ClientTrafficPolicy page for targeting all listeners#8892fallard84 wants to merge 1 commit into
Conversation
Signed-off-by: Francois Allard <allardtech@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dca6d09ec5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| targetSelectors: | ||
| - kind: Gateway | ||
| name: my-gateway # Targets all listeners |
There was a problem hiding this comment.
Switching this example to targetSelectors while keeping name makes the YAML inconsistent with the TargetSelector schema (which supports kind, group, matchLabels, and matchExpressions, but not name). In practice this can either be rejected by validation or silently ignore name, causing the policy to match all Gateways of that kind in-scope instead of only my-gateway, which is not what the example text claims.
Useful? React with 👍 / 👎.
| name: gateway-wide-policy | ||
| spec: | ||
| targetRefs: | ||
| targetSelectors: |
There was a problem hiding this comment.
this matches the comment - " Policy B: Targets the entire gateway"
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
2 participants
What type of PR is this?
docs: fix ClientTrafficPolicy page for targeting all listeners
What this PR does / why we need it: The ClientTrafficPolicy doc incorrectly use targetRefs when targeting all listeners of a gateway. The correct key is targetSelectors.
Which issue(s) this PR fixes:
Fixes #
Release Notes: No