Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ kind: ClientTrafficPolicy
metadata:
name: gateway-wide-policy
spec:
targetRefs:
targetSelectors:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches the comment - " Policy B: Targets the entire gateway"

- kind: Gateway
name: my-gateway # Targets all listeners
Comment on lines +123 to 125

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use valid TargetSelector fields in gateway-wide example

Switching this example to targetSelectors while keeping name makes the YAML inconsistent with the TargetSelector schema (which supports kind, group, matchLabels, and matchExpressions, but not name). In practice this can either be rejected by validation or silently ignore name, causing the policy to match all Gateways of that kind in-scope instead of only my-gateway, which is not what the example text claims.

Useful? React with 👍 / 👎.

timeout:
Expand Down
Loading