feat: request buffer limit#8893
Open
zhaohuabing wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8893 +/- ##
==========================================
- Coverage 75.59% 75.56% -0.03%
==========================================
Files 252 252
Lines 41713 41730 +17
==========================================
+ Hits 31531 31532 +1
- Misses 8057 8067 +10
- Partials 2125 2131 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
guydc
reviewed
May 1, 2026
yashbhuva
approved these changes
Jun 21, 2026
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
api-request-buffer-limit
branch
from
June 22, 2026 08:22
8d0f19b to
0ac8c0d
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Member
Author
|
retest |
Member
Author
|
/retest |
…limit # Conflicts: # release-notes/current.yaml
Member
Author
|
/retest |
kkk777-7
previously approved these changes
Jul 10, 2026
Member
|
LGTM, thanks! |
…limit # Conflicts: # internal/gatewayapi/backendtrafficpolicy.go
Member
|
/retest |
1 similar comment
Member
|
/retest |
zirain
reviewed
Jul 21, 2026
| // +kubebuilder:validation:XIntOrString | ||
| // +kubebuilder:validation:Pattern="^[1-9]+[0-9]*([EPTGMK]i|[EPTGMk])?$" | ||
| // +optional | ||
| RequestBodyBufferLimit *resource.Quantity `json:"requestBodyBufferLimit,omitempty"` |
Member
There was a problem hiding this comment.
not a must, but could this be part of RequestBuffer?
Member
Author
There was a problem hiding this comment.
They have different meanings:
- RequestBuffer: buffer and fully receive each request from a client before continuing to send the request upstream to the backends.
- RequestBodyBufferLimit: specifies the maximum size in bytes that Envoy may buffer for request bodies
I'm afraid it would cause confusion if we include both of them inside one RequestBuffer parent type.
Member
Author
kkk777-7
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #8891
Release note: yes