Skip to content

docs(tasks): add documentation for Dynamic Modules configuration example - #8908

Merged
zirain merged 4 commits into
envoyproxy:mainfrom
sjoukedv:docs/dynamic-module-example
May 6, 2026
Merged

docs(tasks): add documentation for Dynamic Modules configuration example#8908
zirain merged 4 commits into
envoyproxy:mainfrom
sjoukedv:docs/dynamic-module-example

Conversation

@sjoukedv

@sjoukedv sjoukedv commented May 3, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

docs(tasks): add dynamic module configuration example

What this PR does / why we need it:

Dynamic Modules are only present in the spec itself not in the rest of the documentation. This PR provides a real-world example using https://builtonenvoy.io/extensions/coraza-waf/ of how this would be used.

Release Notes: Yes/No

sjoukedv and others added 2 commits May 3, 2026 10:36
Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
…resource

Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
@sjoukedv
sjoukedv requested a review from a team as a code owner May 3, 2026 08:40
@netlify

netlify Bot commented May 3, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 5692943
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69f762bc0ebd3600085cd2a2
😎 Deploy Preview https://deploy-preview-8908--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sjoukedv

sjoukedv commented May 3, 2026

Copy link
Copy Markdown
Contributor Author

Would be great if we can include this in 1.8.0 already as it's the first release with Envoy 1.38.0.

We could also make this example less opinionated by using something from https://github.com/envoyproxy/dynamic-modules-examples, but that's not a real-world example.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a4883651a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread site/content/en/latest/tasks/extensibility/dynamic-modules.md Outdated
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
@zirain

zirain commented May 3, 2026

Copy link
Copy Markdown
Member

@wbpcode @nacx can you help to review this?

…ration instructions

Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
@arkodg arkodg added this to the v1.8.0 Release milestone May 3, 2026
@arkodg
arkodg requested review from jukie and zhaohuabing May 3, 2026 23:19
@nacx

nacx commented May 4, 2026

Copy link
Copy Markdown
Member

The config and guide LGTM

@kkk777-7

kkk777-7 commented May 6, 2026

Copy link
Copy Markdown
Member

LGTM, thanks!

@zirain
zirain merged commit e2f9873 into envoyproxy:main May 6, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants