Skip to content

feat: use grpc status errors in jwtinterceptor - #9020

Merged
kkk777-7 merged 9 commits into
envoyproxy:mainfrom
cnvergence:fix-grpc-status-codes
Jul 22, 2026
Merged

feat: use grpc status errors in jwtinterceptor#9020
kkk777-7 merged 9 commits into
envoyproxy:mainfrom
cnvergence:fix-grpc-status-codes

Conversation

@cnvergence

Copy link
Copy Markdown
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 9566430
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a6052ea2a6d8800070a54dd
😎 Deploy Preview https://deploy-preview-9020--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.59%. Comparing base (198d48a) to head (9566430).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/server/kubejwt/tokenreview.go 0.00% 6 Missing ⚠️
internal/xds/server/kubejwt/jwtinterceptor.go 62.50% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.71%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9020      +/-   ##
==========================================
- Coverage   75.61%   75.59%   -0.03%     
==========================================
  Files         252      252              
  Lines       41742    41743       +1     
==========================================
- Hits        31564    31554      -10     
- Misses       8052     8061       +9     
- Partials     2126     2128       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnvergence

Copy link
Copy Markdown
Member Author

/retest

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
cnvergence force-pushed the fix-grpc-status-codes branch from 123b8dd to 627bbaf Compare May 27, 2026 13:25
@cnvergence
cnvergence marked this pull request as ready for review May 27, 2026 13:25
@cnvergence
cnvergence requested a review from a team as a code owner May 27, 2026 13:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 627bbafe5a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread internal/xds/server/kubejwt/jwtinterceptor.go
@cnvergence

Copy link
Copy Markdown
Member Author

/retest

@cnvergence

Copy link
Copy Markdown
Member Author

/retest

@cnvergence

Copy link
Copy Markdown
Member Author

let's move this one as well

@arkodg

arkodg commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 789624faa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kkk777-7

Copy link
Copy Markdown
Member

LGTM, thanks!

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7
kkk777-7 merged commit 126bdf1 into envoyproxy:main Jul 22, 2026
105 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants