Skip to content

Fix(ext-proc-examples): Add RequestBody and ResponseBody handling in request processing#9183

Merged
arkodg merged 2 commits into
envoyproxy:mainfrom
abe-servescale:main
Jul 20, 2026
Merged

Fix(ext-proc-examples): Add RequestBody and ResponseBody handling in request processing#9183
arkodg merged 2 commits into
envoyproxy:mainfrom
abe-servescale:main

Conversation

@abe-servescale

Copy link
Copy Markdown
Contributor

When following the procedure in the page: link. I noticed an error when sending request to the ext-proc:
Unknown Request type &{body:"{\n \"path\": \"/myapp\",\n \"host\": \"www.example.com\",\n \"method\": \"GET\",\n \"proto\": \"HTTP/1.1\",\n \"headers\": {\n \"Accept\": [\n \"*/*\"\n ],\n \"User-Agent\": [\n \"curl/7.81.0\"\n ],\n \"X-Env │ │ oy-External-Address\": [\n \"127.0.0.1\"\n ],\n \"X-Forwarded-For\": [\n \"10.42.0.9\"\n ],\n \"X-Forwarded-Proto\": [\n \"http\"\n ],\n \"X-Request-Ext-Processed\": [\n \"true\"\n ],\n \"X-Request-Id\": [\n \"3cb7e724-0743-4509-ab4c-7df78decc7a0\"\ │ │ n ]\n },\n \"httpPort\": \"3000\",\n \"namespace\": \"default\",\n \"ingress\": \"\",\n \"service\": \"\",\n \"pod\": \"backend-7878cc679d-t9n7h\"\n}" end_of_stream:true}

I have solved the issue with this edit (done with chatgpt codex).

@abe-servescale
abe-servescale requested a review from a team as a code owner June 6, 2026 00:58
@netlify

netlify Bot commented Jun 6, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit f2f1f68
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a59de27b660660008962413
😎 Deploy Preview https://deploy-preview-9183--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.48%. Comparing base (4d7686c) to head (f2f1f68).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9183      +/-   ##
==========================================
- Coverage   75.48%   75.48%   -0.01%     
==========================================
  Files         252      252              
  Lines       41642    41642              
==========================================
- Hits        31435    31434       -1     
- Misses       8075     8077       +2     
+ Partials     2132     2131       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg
arkodg requested a review from guydc June 8, 2026 02:03
@arkodg arkodg added this to the v1.9.0 Release milestone Jun 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jul 8, 2026
@abe-servescale

Copy link
Copy Markdown
Contributor Author

@guydc @arkodg Hi, do you need me to edit some things or this can be closed?

@github-actions github-actions Bot removed the stale label Jul 10, 2026
arkodg
arkodg previously approved these changes Jul 11, 2026

@arkodg arkodg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@arkodg

arkodg commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@abe-servescale, DCO is failing, can you sign your commit and force push

…uests

Signed-off-by: Andrea Abellonio <andrea.abellonio@servescale.ai>
@arkodg
arkodg merged commit 8b702cc into envoyproxy:main Jul 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants